From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Cursor on images not visible Date: Tue, 14 Feb 2006 03:42:19 +0200 Organization: JURTA Message-ID: <87lkweiruc.fsf@jurta.org> References: <874q3b8jj1.fsf_-_@jurta.org> <871wyce4ek.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1139893716 31369 80.91.229.2 (14 Feb 2006 05:08:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 14 Feb 2006 05:08:36 +0000 (UTC) Cc: emacs-devel@gnu.org, storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 14 06:08:33 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F8sQ5-0007rc-Vk for ged-emacs-devel@m.gmane.org; Tue, 14 Feb 2006 06:08:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F8sQ5-0005a3-Bt for ged-emacs-devel@m.gmane.org; Tue, 14 Feb 2006 00:08:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F8sOO-0004KX-UN for emacs-devel@gnu.org; Tue, 14 Feb 2006 00:06:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F8sON-0004JV-Ho for emacs-devel@gnu.org; Tue, 14 Feb 2006 00:06:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F8sOM-0004Is-0Y for emacs-devel@gnu.org; Tue, 14 Feb 2006 00:06:22 -0500 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F8sSm-0004gt-VY; Tue, 14 Feb 2006 00:10:57 -0500 Original-Received: from mail.neti.ee (80-235-33-157-dsl.mus.estpak.ee [80.235.33.157]) by Relayhost2.neti.ee (Postfix) with ESMTP id 29EF11AA2; Tue, 14 Feb 2006 07:06:10 +0200 (EET) Original-To: rms@gnu.org In-Reply-To: (Richard M. Stallman's message of "Sun, 12 Feb 2006 14:28:43 -0500") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50512 Archived-At: > If we ever want to make a full web browser in emacs, we definitely > need to be able to "glue" images together without any margins around > them. (I have some ideas how to modify the redisplay engine to allow > this, but that for emacs 24.x)... > > Ok, so that solution is out. > > Should we change some specific packages now to add some margins? The file that needs this the most is wid-edit.el. When the cursor type is `bar', typing TAB repeatedly on a column of checkboxes for face attributes in the face customization buffer has no visual feedback at all. I propose the patch below to add 1-pixel margin around checkbox images. Another place where I noticed this problem is thumbnail packages. This will be fixed soon separately. Index: lisp/wid-edit.el =================================================================== RCS file: /sources/emacs/emacs/lisp/wid-edit.el,v retrieving revision 1.163 diff -c -r1.163 wid-edit.el *** lisp/wid-edit.el 6 Feb 2006 14:33:35 -0000 1.163 --- lisp/wid-edit.el 14 Feb 2006 01:35:32 -0000 *************** *** 2158,2163 **** --- 2158,2164 ---- :background "grey75" ; like default mode line :foreground "black" :relief -2 + :margin 1 :ascent 'center) :off "[ ]" :off-glyph '(create-image (make-string 8 0) *************** *** 2165,2170 **** --- 2166,2172 ---- :background "grey75" :foreground "black" :relief -2 + :margin 1 :ascent 'center) :help-echo "Toggle this item." :action 'widget-checkbox-action) -- Juri Linkov http://www.jurta.org/emacs/