unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org, storm@cua.dk
Subject: Re: Cursor on images not visible
Date: Tue, 14 Feb 2006 03:42:19 +0200	[thread overview]
Message-ID: <87lkweiruc.fsf@jurta.org> (raw)
In-Reply-To: <E1F8Mtn-0006p5-IH@fencepost.gnu.org> (Richard M. Stallman's message of "Sun, 12 Feb 2006 14:28:43 -0500")

>     If we ever want to make a full web browser in emacs, we definitely
>     need to be able to "glue" images together without any margins around
>     them.  (I have some ideas how to modify the redisplay engine to allow
>     this, but that for emacs 24.x)...
>
> Ok, so that solution is out.
>
> Should we change some specific packages now to add some margins?

The file that needs this the most is wid-edit.el.  When the cursor type is
`bar', typing TAB repeatedly on a column of checkboxes for face attributes
in the face customization buffer has no visual feedback at all.  I propose
the patch below to add 1-pixel margin around checkbox images.

Another place where I noticed this problem is thumbnail packages.
This will be fixed soon separately.

Index: lisp/wid-edit.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/wid-edit.el,v
retrieving revision 1.163
diff -c -r1.163 wid-edit.el
*** lisp/wid-edit.el	6 Feb 2006 14:33:35 -0000	1.163
--- lisp/wid-edit.el	14 Feb 2006 01:35:32 -0000
***************
*** 2158,2163 ****
--- 2158,2164 ----
  			   :background "grey75"	; like default mode line
  			   :foreground "black"
  			   :relief -2
+ 			   :margin 1
  			   :ascent 'center)
    :off "[ ]"
    :off-glyph '(create-image (make-string 8 0)
***************
*** 2165,2170 ****
--- 2166,2172 ----
  			    :background "grey75"
  			    :foreground "black"
  			    :relief -2
+ 			    :margin 1
  			    :ascent 'center)
    :help-echo "Toggle this item."
    :action 'widget-checkbox-action)

-- 
Juri Linkov
http://www.jurta.org/emacs/

  reply	other threads:[~2006-02-14  1:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-07 10:57 Cursor on images not visible Juri Linkov
2006-02-09 17:48 ` Richard M. Stallman
2006-02-09 19:18   ` Juri Linkov
2006-02-10 23:02     ` Richard M. Stallman
2006-02-11 18:51       ` Kim F. Storm
2006-02-12  0:57         ` David Kastrup
2006-02-12 19:28         ` Richard M. Stallman
2006-02-14  1:42           ` Juri Linkov [this message]
2006-02-14  9:20             ` martin rudalics
2006-02-14 17:46               ` Juri Linkov
2006-02-20  0:54                 ` Juri Linkov
2006-02-14 21:27               ` Kim F. Storm
2006-02-15 10:14                 ` martin rudalics
2006-02-14 22:17             ` Richard M. Stallman
2006-02-13  0:40         ` David Kastrup
2006-02-15 12:51           ` Kim F. Storm
2006-02-10 10:17   ` Mathias Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lkweiruc.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).