Feature request: extending cross-reference in *Help* buffers

Feature request: extending cross-reference in *Help* buffers

[Slawomir Nowaczyk]

Hello,

The help window that "C-h f" (and others) open contains name of a file
in which given function is defined. It looks like this:

,----
| python-mode is an interactive Lisp function in `python.el'.
| (python-mode)
| ...
`----

and the name "python.el" text is a cross-reference. On the other hand,
the quote and dot after it are not. Would it be possible to extend the
cross-reference to those characters as well? 

It would allow C-e RET to visit the file... right now I often find
myself having to do C-a C-b C-b RET (which is twice as long :-)

-- 
 Best wishes,
   Slawomir Nowaczyk
     ( slawomir.nowaczyk.847@student.lu.se )

Tact is the knack of making a point without making an enemy.

RE: Feature request: extending cross-reference in *Help* buffers

[Drew Adams]

    Would it be possible to extend the
    cross-reference to those characters as well?     
    It would allow C-e RET to visit the file... right now I often find
    myself having to do C-a C-b C-b RET (which is twice as long :-)
    
I prefer the current hot-spot extent (just the name), but I don't have a good reason, other than appearance.
    

Re: Feature request: extending cross-reference in *Help* buffers

[Yoni Rabkin Katzenell]

Slawomir Nowaczyk <slawomir.nowaczyk.847@student.lu.se> writes:

> Hello,
>
> The help window that "C-h f" (and others) open contains name of a file
> in which given function is defined. It looks like this:
>
> ,----
> | python-mode is an interactive Lisp function in `python.el'.
> | (python-mode)
> | ...
> `----
>
> and the name "python.el" text is a cross-reference. On the other hand,
> the quote and dot after it are not. Would it be possible to extend the
> cross-reference to those characters as well? 
>
> It would allow C-e RET to visit the file... right now I often find
> myself having to do C-a C-b C-b RET (which is twice as long :-)

In GNU Emacs 22.0.50.1 of 2006-08-18, pressing TAB RET visits the file
for me. Is that not short enough?

-- 
   "Cut your own wood and it will warm you twice"

Re: Feature request: extending cross-reference in *Help* buffers

[Richard Stallman]

Does this give good results?

*** help-fns.el	11 Jul 2006 12:29:57 -0400	1.90
--- help-fns.el	25 Aug 2006 08:49:12 -0400	
***************
*** 369,386 ****
        (setq file-name (if (get-buffer " *DOC*")
  			  (help-C-file-name def 'subr)
  			'C-source)))
!     (when file-name
!       (princ " in `")
!       ;; We used to add .el to the file name,
!       ;; but that's completely wrong when the user used load-file.
!       (princ (if (eq file-name 'C-source) "C source code" file-name))
!       (princ "'")
!       ;; Make a hyperlink to the library.
!       (with-current-buffer standard-output
!         (save-excursion
! 	  (re-search-backward "`\\([^`']+\\)'" nil t)
! 	  (help-xref-button 1 'help-function-def function file-name))))
!     (princ ".")
      (terpri)
      (when (commandp function)
        (let* ((remapped (command-remapping function))
--- 369,387 ----
        (setq file-name (if (get-buffer " *DOC*")
  			  (help-C-file-name def 'subr)
  			'C-source)))
!     (if file-name
! 	(progn
! 	  (princ " in `")
! 	  ;; We used to add .el to the file name,
! 	  ;; but that's completely wrong when the user used load-file.
! 	  (princ (if (eq file-name 'C-source) "C source code" file-name))
! 	  (princ "'.")
! 	  ;; Make a hyperlink to the library.
! 	  (with-current-buffer standard-output
! 	    (save-excursion
! 	      (re-search-backward "`\\([^`']+\\)'" nil t)
! 	      (help-xref-button 0 'help-function-def function file-name))))
!       (princ "."))
      (terpri)
      (when (commandp function)
        (let* ((remapped (command-remapping function))

Re: Feature request: extending cross-reference in *Help* buffers

[Slawomir Nowaczyk]

On Fri, 25 Aug 2006 12:52:54 +0300
Yoni Rabkin Katzenell <yoni-r@actcom.com> wrote:

#> In GNU Emacs 22.0.50.1 of 2006-08-18, pressing TAB RET visits the file
#> for me. Is that not short enough?

It most definitely is :-)

Thank you, I didn't know about that.

-- 
 Best wishes,
   Slawomir Nowaczyk
     ( slawomir.nowaczyk.847@student.lu.se )

Rules of Optimization:
  Rule 1: Don't do it.
  Rule 2 (for experts only): Don't do it yet.

Re: Feature request: extending cross-reference in *Help* buffers

[Slawomir Nowaczyk]

On Fri, 25 Aug 2006 16:24:12 -0400
Richard Stallman <rms@gnu.org> wrote:

#> Does this give good results?

Well, not quite what I had in mind... My idea was to have the dot and,
preferably, the newline included in the cross-reference as well: thus
having C-e RET follow the link.

The result is, however, aesthetically ugly, so maybe it is not really a
good idea... Especially since Yoni's solution of using TAB RET works
perfectly.

-- 
 Best wishes,
   Slawomir Nowaczyk
     ( slawomir.nowaczyk.847@student.lu.se )

May your doorstep ever be dirty.
   - Romany blessing

Re: Feature request: extending cross-reference in *Help* buffers

[Richard Stallman]

    In GNU Emacs 22.0.50.1 of 2006-08-18, pressing TAB RET visits the file
    for me. Is that not short enough?

I did not know there was such an easy method available.
I guess no change is needed.