From: Chong Yidong <cyd@stupidchicken.com>
To: emacs-devel@gnu.org
Subject: Image-mode enhancements (post-release)
Date: Wed, 23 May 2007 13:54:41 -0400 [thread overview]
Message-ID: <87lkff8ly6.fsf@stupidchicken.com> (raw)
One important enhancement I would like to get into Emacs 23 (and maybe
Emacs 22.2 too) is image scrolling for image-mode. Currently, images
that are wider or taller than the Emacs window aren't handled very
well; you can scroll up and down using next-line and previous-line,
but not sideways (and, annoyingly, scrolling to the bottom of such
images loops back to the top).
The following patch implements the necessary image-scrolling
functions, and remaps the normal navigation keybindings (forward-char,
previous-line, scroll-up, etc.) to use these functions when image-mode
is displaying the image as an image.
One other useful feature which is not currently implemented would be
to resize the image to fit the Emacs window if it is too large, and to
provide a way to toggle between the full-sized and window-fitted
versions of the image (Firefox has a similar feature).
Comments are welcome.
*** emacs/lisp/image-mode.el.~1.22.~ 2007-05-21 18:43:47.000000000 -0400
--- emacs/lisp/image-mode.el 2007-05-23 13:45:59.000000000 -0400
***************
*** 43,53 ****
;;;###autoload (push '("\\.p[bpgn]m\\'" . image-mode) auto-mode-alist)
;;;###autoload (push '("\\.x[bp]m\\'" . image-mode-maybe) auto-mode-alist)
(defvar image-mode-map
(let ((map (make-sparse-keymap)))
(define-key map "\C-c\C-c" 'image-toggle-display)
map)
! "Major mode keymap for Image mode.")
;;;###autoload
(defun image-mode ()
--- 43,204 ----
;;;###autoload (push '("\\.p[bpgn]m\\'" . image-mode) auto-mode-alist)
;;;###autoload (push '("\\.x[bp]m\\'" . image-mode-maybe) auto-mode-alist)
+ ;;; Image scrolling functions
+
+ (defun image-forward-hscroll (&optional n)
+ "Scroll image in current window to the left by N character widths.
+ Stop if the right edge of the image is reached."
+ (interactive "p")
+ (cond ((= n 0) nil)
+ ((< n 0)
+ (set-window-hscroll (selected-window)
+ (max 0 (+ (window-hscroll) n))))
+ (t
+ (let* ((image (get-text-property 1 'display))
+ (edges (window-inside-edges))
+ (win-width (- (nth 2 edges) (nth 0 edges)))
+ (img-width (ceiling (car (image-size image)))))
+ (set-window-hscroll (selected-window)
+ (min (max 0 (- img-width win-width))
+ (+ n (window-hscroll))))))))
+
+ (defun image-backward-hscroll (&optional n)
+ "Scroll image in current window to the right by N character widths.
+ Stop if the left edge of the image is reached."
+ (interactive "p")
+ (image-forward-hscroll (- n)))
+
+ (defun image-next-line (&optional n)
+ "Scroll image in current window upward by N lines.
+ Stop if the bottom edge of the image is reached."
+ (interactive "p")
+ (cond ((= n 0) nil)
+ ((< n 0)
+ (set-window-vscroll (selected-window)
+ (max 0 (+ (window-vscroll) n))))
+ (t
+ (let* ((image (get-text-property 1 'display))
+ (edges (window-inside-edges))
+ (win-height (- (nth 3 edges) (nth 1 edges)))
+ (img-height (ceiling (cdr (image-size image)))))
+ (set-window-vscroll (selected-window)
+ (min (max 0 (- img-height win-height))
+ (+ n (window-vscroll))))))))
+
+ (defun image-previous-line (&optional n)
+ "Scroll image in current window downward by N lines.
+ Stop if the top edge of the image is reached."
+ (interactive "p")
+ (image-next-line (- n)))
+
+ (defun image-scroll-up (&optional n)
+ "Scroll image in current window upward by N lines.
+ Stop if the bottom edge of the image is reached.
+ If ARG is omitted or nil, scroll upward by a near full screen.
+ A near full screen is `next-screen-context-lines' less than a full screen.
+ Negative ARG means scroll downward.
+ If ARG is the atom `-', scroll downward by nearly full screen.
+ When calling from a program, supply as argument a number, nil, or `-'."
+ (interactive "P")
+ (cond ((null n)
+ (let* ((edges (window-inside-edges))
+ (win-height (- (nth 3 edges) (nth 1 edges))))
+ (image-next-line
+ (max 0 (- win-height next-screen-context-lines)))))
+ ((eq n '-)
+ (let* ((edges (window-inside-edges))
+ (win-height (- (nth 3 edges) (nth 1 edges))))
+ (image-next-line
+ (min 0 (- next-screen-context-lines win-height)))))
+ (t (image-next-line (prefix-numeric-value n)))))
+
+ (defun image-scroll-down (&optional n)
+ "Scroll image in current window downward by N lines
+ Stop if the top edge of the image is reached.
+ If ARG is omitted or nil, scroll downward by a near full screen.
+ A near full screen is `next-screen-context-lines' less than a full screen.
+ Negative ARG means scroll upward.
+ If ARG is the atom `-', scroll upward by nearly full screen.
+ When calling from a program, supply as argument a number, nil, or `-'."
+ (interactive "P")
+ (cond ((null n)
+ (let* ((edges (window-inside-edges))
+ (win-height (- (nth 3 edges) (nth 1 edges))))
+ (image-next-line
+ (min 0 (- next-screen-context-lines win-height)))))
+ ((eq n '-)
+ (let* ((edges (window-inside-edges))
+ (win-height (- (nth 3 edges) (nth 1 edges))))
+ (image-next-line
+ (max 0 (- win-height next-screen-context-lines)))))
+ (t (image-next-line (- (prefix-numeric-value n))))))
+
+ (defun image-bol (arg)
+ "Scroll horizontally to the left edge of the image in the current window.
+ With argument ARG not nil or 1, move forward ARG - 1 lines first,
+ stopping if the top or bottom edge of the image is reached."
+ (interactive "p")
+ (and arg
+ (/= (setq arg (prefix-numeric-value arg)) 1)
+ (image-next-line (- arg 1)))
+ (set-window-hscroll (selected-window) 0))
+
+ (defun image-eol (arg)
+ "Scroll horizontally to the right edge of the image in the current window.
+ With argument ARG not nil or 1, move forward ARG - 1 lines first,
+ stopping if the top or bottom edge of the image is reached."
+ (interactive "p")
+ (and arg
+ (/= (setq arg (prefix-numeric-value arg)) 1)
+ (image-next-line (- arg 1)))
+ (let* ((image (get-text-property 1 'display))
+ (edges (window-inside-edges))
+ (win-width (- (nth 2 edges) (nth 0 edges)))
+ (img-width (ceiling (car (image-size image)))))
+ (set-window-hscroll (selected-window)
+ (max 0 (- img-width win-width)))))
+
+ (defun image-bob ()
+ "Scroll to the top-left corner of the image in the current window."
+ (interactive)
+ (set-window-hscroll (selected-window) 0)
+ (set-window-vscroll (selected-window) 0))
+
+ (defun image-eob ()
+ "Scroll to the bottom-right corner of the image in the current window."
+ (interactive)
+ (let* ((image (get-text-property 1 'display))
+ (edges (window-inside-edges))
+ (win-width (- (nth 2 edges) (nth 0 edges)))
+ (img-width (ceiling (car (image-size image))))
+ (win-height (- (nth 3 edges) (nth 1 edges)))
+ (img-height (ceiling (cdr (image-size image)))))
+ (set-window-hscroll (selected-window) (max 0 (- img-width win-width)))
+ (set-window-vscroll (selected-window) (max 0 (- img-height win-height)))))
+
+ ;;; Image Mode setup
+
(defvar image-mode-map
(let ((map (make-sparse-keymap)))
(define-key map "\C-c\C-c" 'image-toggle-display)
+ (define-key map [remap forward-char] 'image-forward-hscroll)
+ (define-key map [remap backward-char] 'image-backward-hscroll)
+ (define-key map [remap previous-line] 'image-previous-line)
+ (define-key map [remap next-line] 'image-next-line)
+ (define-key map [remap scroll-up] 'image-scroll-up)
+ (define-key map [remap scroll-down] 'image-scroll-down)
+ (define-key map [remap move-beginning-of-line] 'image-bol)
+ (define-key map [remap move-end-of-line] 'image-eol)
+ (define-key map [remap beginning-of-buffer] 'image-bob)
+ (define-key map [remap end-of-buffer] 'image-eob)
+ map)
+ "Major mode keymap for viewing images in Image mode.")
+
+ (defvar image-mode-text-map
+ (let ((map (make-sparse-keymap)))
+ (define-key map "\C-c\C-c" 'image-toggle-display)
map)
! "Major mode keymap for viewing images as text in Image mode.")
;;;###autoload
(defun image-mode ()
***************
*** 58,70 ****
(kill-all-local-variables)
(setq mode-name "Image")
(setq major-mode 'image-mode)
- (use-local-map image-mode-map)
(add-hook 'change-major-mode-hook 'image-toggle-display-text nil t)
(if (and (display-images-p)
(not (get-text-property (point-min) 'display)))
(image-toggle-display)
;; Set next vars when image is already displayed but local
;; variables were cleared by kill-all-local-variables
(setq cursor-type nil truncate-lines t))
(run-mode-hooks 'image-mode-hook)
(if (display-images-p)
--- 209,221 ----
(kill-all-local-variables)
(setq mode-name "Image")
(setq major-mode 'image-mode)
(add-hook 'change-major-mode-hook 'image-toggle-display-text nil t)
(if (and (display-images-p)
(not (get-text-property (point-min) 'display)))
(image-toggle-display)
;; Set next vars when image is already displayed but local
;; variables were cleared by kill-all-local-variables
+ (use-local-map image-mode-map)
(setq cursor-type nil truncate-lines t))
(run-mode-hooks 'image-mode-hook)
(if (display-images-p)
***************
*** 140,145 ****
--- 291,298 ----
(set-buffer-modified-p modified)
(kill-local-variable 'cursor-type)
(kill-local-variable 'truncate-lines)
+ (kill-local-variable 'auto-hscroll-mode)
+ (use-local-map image-mode-text-map)
(if (called-interactively-p)
(message "Repeat this command to go back to displaying the image")))
;; Turn the image data into a real image, but only if the whole file
***************
*** 161,172 ****
nil t)))
(props
`(display ,image
! intangible ,image
! rear-nonsticky (display intangible)
! ;; This a cheap attempt to make the whole buffer
! ;; read-only when we're visiting the file (as
! ;; opposed to just inserting it).
! read-only t front-sticky (read-only)))
(inhibit-read-only t)
(buffer-undo-list t)
(modified (buffer-modified-p)))
--- 314,322 ----
nil t)))
(props
`(display ,image
! intangible ,image
! rear-nonsticky (display intangible)
! read-only t front-sticky (read-only)))
(inhibit-read-only t)
(buffer-undo-list t)
(modified (buffer-modified-p)))
***************
*** 179,184 ****
--- 329,337 ----
;; This just makes the arrow displayed in the right fringe
;; area look correct when the image is wider than the window.
(setq truncate-lines t)
+ ;; Allow navigation of large images
+ (set (make-local-variable 'auto-hscroll-mode) nil)
+ (use-local-map image-mode-map)
(if (called-interactively-p)
(message "Repeat this command to go back to displaying the file as text")))))
next reply other threads:[~2007-05-23 17:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 17:54 Chong Yidong [this message]
2007-05-23 18:47 ` Image-mode enhancements (post-release) David Kastrup
2007-05-23 19:48 ` Chong Yidong
2007-05-23 19:53 ` Mathias Dahl
2007-05-23 23:46 ` Richard Stallman
2007-05-24 6:57 ` David Kastrup
2007-05-23 22:44 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lkff8ly6.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).