unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tassilo@member.fsf.org>
To: rms@gnu.org
Cc: dto@gnu.org, emacs-devel@gnu.org
Subject: Re: comment-add
Date: Tue, 11 Dec 2007 21:34:54 +0100	[thread overview]
Message-ID: <87lk816kcx.fsf@member.fsf.org> (raw)
In-Reply-To: <E1J2ALR-0004Is-19@fencepost.gnu.org> (Richard Stallman's message of "Tue, 11 Dec 2007 14:00:41 -0500")

Richard Stallman <rms@gnu.org> writes:

> To help me reproduce the problem, could you please post a *precise*
> test case for this bug?

1. emacs -Q

2. Goto buffer *scratch*

3. M-x outline-minor-mode

4. Insert:

(defun foo ()
  (do-this)
  (do-that)
  (do-another-thing))

The "(defun foo ()" is matched by outline-regexp.

5. Mark the whole function foo and do M-x comment-region.  This results
in:

;;; (defun foo ()
;;;   (do-this)
;;;   (do-that)
;;;   (do-another-thing))

Now the ";;; (defun foo ()" is still matched by outline-regexp.  That's
the difference between the new default comment-style `indent-or-triple'
and the old default `indent'.

> Also please say exactly what incorrect results you get.

I don't know if having differences in what commented text is matched by
outline-regexp qualifies as a bug, but ideally switching comment-style
shouldn't change that.  So the comment-style `indent-or-triple' should
ensure that ;;; is followed by more than one space if it starts at
column 0.

Bye,
Tassilo

  reply	other threads:[~2007-12-11 20:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-24 22:55 comment-add Stephen Berman
2007-09-25  9:39 ` comment-add David O'Toole
2007-09-25 23:35   ` comment-add Richard Stallman
2007-11-06 20:59     ` comment-add Tassilo Horn
2007-12-10 15:19       ` comment-add Richard Stallman
2007-12-10 19:41         ` comment-add Tassilo Horn
2007-12-11 19:00           ` comment-add Richard Stallman
2007-12-11 20:34             ` Tassilo Horn [this message]
2007-12-15 21:36               ` comment-add Richard Stallman
2007-09-25 16:07 ` comment-add Stefan Monnier
2007-09-25 21:48   ` comment-add Eli Zaretskii
2007-09-25 17:57 ` comment-add Richard Stallman
2007-09-25 22:27   ` comment-add Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lk816kcx.fsf@member.fsf.org \
    --to=tassilo@member.fsf.org \
    --cc=dto@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).