From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: 23.0.60; find-backup-file-name assumes base name of backup file names Date: Mon, 07 Apr 2008 11:18:25 -0400 Message-ID: <87lk3phewu.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207581524 10129 80.91.229.12 (7 Apr 2008 15:18:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Apr 2008 15:18:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Ramkumar R. Aiyengar" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 07 17:19:16 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jit7r-0007KQ-PX for ged-emacs-devel@m.gmane.org; Mon, 07 Apr 2008 17:19:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jit7E-0002Sk-JW for ged-emacs-devel@m.gmane.org; Mon, 07 Apr 2008 11:18:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jit7A-0002Rz-L3 for emacs-devel@gnu.org; Mon, 07 Apr 2008 11:18:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jit79-0002RR-T3 for emacs-devel@gnu.org; Mon, 07 Apr 2008 11:18:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jit79-0002RM-Lt for emacs-devel@gnu.org; Mon, 07 Apr 2008 11:18:31 -0400 Original-Received: from c-98-216-111-182.hsd1.ma.comcast.net ([98.216.111.182] helo=furry) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jit79-000805-CE for emacs-devel@gnu.org; Mon, 07 Apr 2008 11:18:31 -0400 Original-Received: by furry (Postfix, from userid 1000) id 34E81C045; Mon, 7 Apr 2008 11:18:25 -0400 (EDT) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94575 Archived-At: > make-backup-file-name-function is a customizable variable in files.el > for deciding the backup file name for a file. find-backup-file-name > uses make-backup-file-name-1 for finding out the base names of the > backup files: > > (let* ((basic-name (make-backup-file-name-1 fn)) > (base-versions (concat (file-name-nondirectory basic-name) > ".~")) > > This assumes that make-backup-file-name is used for generating the > backup file names, while make-backup-file-name-function could be > customized. The result of this is, any customization to > make-backup-file-name-function doesn't work as expected when the > backup file name is in a different place than what is provided by the > stock function (like say, a different directory). In the code, find-backup-file-name only uses make-backup-file-name-1 when checking for numeric backup files (usually for files under version control). If it determines that a non-numeric backup file is desired, it calls make-backup-file-name, which correctly checks make-backup-file-name-function as desired. Note that make-backup-file-name-function only applies to non-numeric backup files. So I think there is no problem here, unless you can give instructions for reproducing a bug.