From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: Unicode handling breaks Jpeg image detection? Date: Fri, 04 Jul 2008 10:40:41 +0200 Message-ID: <87lk0ioxdi.fsf@escher.local.home> References: <87od5qbn0b.fsf@stupidchicken.com> <87tzfhadwr.fsf@escher.local.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1215160889 3061 80.91.229.12 (4 Jul 2008 08:41:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Jul 2008 08:41:29 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 04 10:42:16 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KEgrt-0004rU-GL for ged-emacs-devel@m.gmane.org; Fri, 04 Jul 2008 10:42:14 +0200 Original-Received: from localhost ([127.0.0.1]:42678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEgr1-0004l8-Uh for ged-emacs-devel@m.gmane.org; Fri, 04 Jul 2008 04:41:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEgqt-0004jf-VB for emacs-devel@gnu.org; Fri, 04 Jul 2008 04:41:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEgqr-0004iK-KL for emacs-devel@gnu.org; Fri, 04 Jul 2008 04:41:10 -0400 Original-Received: from [199.232.76.173] (port=43106 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEgqr-0004i6-8b for emacs-devel@gnu.org; Fri, 04 Jul 2008 04:41:09 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:57399 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KEgqq-0005H3-2Z for emacs-devel@gnu.org; Fri, 04 Jul 2008 04:41:08 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KEgqa-0003W9-PN for emacs-devel@gnu.org; Fri, 04 Jul 2008 08:40:52 +0000 Original-Received: from i5387d963.versanet.de ([83.135.217.99]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 04 Jul 2008 08:40:52 +0000 Original-Received: from stephen.berman by i5387d963.versanet.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 04 Jul 2008 08:40:52 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: i5387d963.versanet.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100331 Archived-At: On Fri, 04 Jul 2008 16:20:26 +0900 Kenichi Handa wrote: > Sorry for the late response. > > In article <87tzfhadwr.fsf@escher.local.home>, Stephen Berman writes: > >> This fix results in a file mode specification error. To reproduce: >> 1. C-x C-f /tmp/test >> 2. Type the letter "รค" (a-umlaut). >> 3. C-x C-s >> 4. C-x k RET >> 5. C-x C-f /tmp/test >> ==> File mode specification error: (error "Can't convert the 0th >> character to unibyte") > > It seems that this bug is already fixed by Juanma (thanks). > > 2008-06-27 Juanma Barranquero > > * image.el (image-jpeg-p): Don't fail if the arg cannot be converted > to unibyte; just assume it is not a JPEG. Use `string-match-p'. > (image-type-from-data, image-type-from-file-name): Use `string-match-p'. > (image-type-from-buffer): Use `looking-at-p'. Yes, I saw that. Thanks from me too. Steve Berman