make the button face inherit from link

make the button face inherit from link

[Dan Nicolaescu]

Last time this was discussed was during the feature freeze.
Any objection to making this change now?


--- lisp/button.el  5 Jan 2009 03:18:46 -0000   1.38
+++ lisp/button.el  21 Jun 2009 00:59:59 -0000
@@ -49,13 +49,7 @@
 
 ;; Globals
 
-;; Use color for the MS-DOS port because it doesn't support underline.
-;; FIXME if MS-DOS correctly answers the (supports) question, it need
-;; no longer be a special case.
-(defface button '((((type pc) (class color))
-                   (:foreground "lightblue"))
-                                  (((supports :underline t)) :underline t)
-                                                (t (:foreground "lightblue")))
+(defface button '((t (:inherit link)))
   "Default face used for buttons."
   :group 'basic-faces)
 

Re: make the button face inherit from link

[Eli Zaretskii]

> Date: Mon, 22 Jun 2009 21:33:13 -0700 (PDT)
> From: Dan Nicolaescu <dann@ics.uci.edu>
> 
> 
> Last time this was discussed was during the feature freeze.
> Any objection to making this change now?

Please wait a few days until I will be able to verify that the patch
actually works in the MS-DOS port.  I'm traveling with no access to
the platform where I have the DOS development environment.  I will be
home in a day or two and will check then.

Thanks.

Re: make the button face inherit from link

[Juri Linkov]

> Last time this was discussed was during the feature freeze.
> Any objection to making this change now?

But the etc/TODO file has a different task added during the feature freeze:

** Add "link" button class
   Add a standard button-class named "link", and make all other link-like
   button classes inherit from it.  Set the default face of the "link" button
   class to the standard "link" face.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: make the button face inherit from link

[Dan Nicolaescu]

Juri Linkov <juri@jurta.org> writes:

  > > Last time this was discussed was during the feature freeze.
  > > Any objection to making this change now?
  > 
  > But the etc/TODO file has a different task added during the feature freeze:
  > 
  > ** Add "link" button class
  >    Add a standard button-class named "link", and make all other link-like
  >    button classes inherit from it.  Set the default face of the "link" button
  >    class to the standard "link" face.

Even better, but it's hard to be sure what the exact meaning is...
What is a button-class?
What are all the link-like button classes?

Miles?

Re: make the button face inherit from link

[Juri Linkov]

>   > ** Add "link" button class
>   >    Add a standard button-class named "link", and make all other link-like
>   >    button classes inherit from it.  Set the default face of the "link" button
>   >    class to the standard "link" face.
>
> Even better, but it's hard to be sure what the exact meaning is...
> What is a button-class?
> What are all the link-like button classes?

This is explained in http://thread.gmane.org/gmane.emacs.devel/56168/focus=56240

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: make the button face inherit from link

[Dan Nicolaescu]

Juri Linkov <juri@jurta.org> writes:

  > >   > ** Add "link" button class
  > >   >    Add a standard button-class named "link", and make all other link-like
  > >   >    button classes inherit from it.  Set the default face of the "link" button
  > >   >    class to the standard "link" face.
  > >
  > > Even better, but it's hard to be sure what the exact meaning is...
  > > What is a button-class?
  > > What are all the link-like button classes?
  > 
  > This is explained in http://thread.gmane.org/gmane.emacs.devel/56168/focus=56240

Unfortunately that doesn't make it any more clear to me.
So I'll just give up on this one, hopefully someone else will figure it
out and DTRT.

Re: make the button face inherit from link

[Lennart Borgman]

On Thu, Jun 25, 2009 at 1:08 AM, Dan Nicolaescu<dann@ics.uci.edu> wrote:
> Juri Linkov <juri@jurta.org> writes:
>
>  > >   > ** Add "link" button class
>  > >   >    Add a standard button-class named "link", and make all other link-like
>  > >   >    button classes inherit from it.  Set the default face of the "link" button
>  > >   >    class to the standard "link" face.
>  > >
>  > > Even better, but it's hard to be sure what the exact meaning is...
>  > > What is a button-class?
>  > > What are all the link-like button classes?
>  >
>  > This is explained in http://thread.gmane.org/gmane.emacs.devel/56168/focus=56240
>
> Unfortunately that doesn't make it any more clear to me.
> So I'll just give up on this one, hopefully someone else will figure it
> out and DTRT.

Miles wrote "Probably the _majority_ of buttons used in the Emacs distrution act
basically like links". I agree to that.

However Miles made a suggestion to create a standard button-class
named link. I don't agree to that, or I at least doubt it is the best
solution. It seems less work to me to take care of the deviations when
the buttons should not look like links.

Also, please do not forget the widgets that acts like links. These
should IMO also use the standard "link" face.

Re: make the button face inherit from link

[Juri Linkov]

> Miles wrote "Probably the _majority_ of buttons used in the Emacs
> distrution act basically like links". I agree to that.
>
> However Miles made a suggestion to create a standard button-class
> named link. I don't agree to that, or I at least doubt it is the best
> solution. It seems less work to me to take care of the deviations when
> the buttons should not look like links.

I guess our task is to find all such deviations, isn't it?  I think
one of them is the output of `list-faces-display' where too much blue
color will clutter the buffer.  Could you find more deviations?

-- 
Juri Linkov
http://www.jurta.org/emacs/