From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs/lisp image.el Date: Sun, 30 Aug 2009 01:46:23 +0300 Organization: JURTA Message-ID: <87ljl2z3ex.fsf@mail.jurta.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1251586433 30828 80.91.229.12 (29 Aug 2009 22:53:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Aug 2009 22:53:53 +0000 (UTC) Cc: Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 30 00:53:46 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MhWnn-0006zy-VQ for ged-emacs-devel@m.gmane.org; Sun, 30 Aug 2009 00:53:44 +0200 Original-Received: from localhost ([127.0.0.1]:45828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhWnn-0006HC-ED for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 18:53:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhWni-0006EX-9X for emacs-devel@gnu.org; Sat, 29 Aug 2009 18:53:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhWnd-000695-Dj for emacs-devel@gnu.org; Sat, 29 Aug 2009 18:53:37 -0400 Original-Received: from [199.232.76.173] (port=55155 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhWnd-00068o-7x for emacs-devel@gnu.org; Sat, 29 Aug 2009 18:53:33 -0400 Original-Received: from smtp-out1.starman.ee ([85.253.0.3]:57697 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhWnc-00031K-KL for emacs-devel@gnu.org; Sat, 29 Aug 2009 18:53:32 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.52.53.cable.starman.ee [82.131.52.53]) by mx1.starman.ee (Postfix) with ESMTP id 9A7FB3F41D6; Sun, 30 Aug 2009 01:53:24 +0300 (EEST) In-Reply-To: (Juanma Barranquero's message of "Sat, 29 Aug 2009 02:21:24 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114854 Archived-At: >> Log message: >> =A0 =A0 =A0 =A0(image-type-header-regexps): Use only JPEG magic number >> =A0 =A0 =A0 =A0to determine JPEG images, and don't use `image-jpeg-p' = because >> =A0 =A0 =A0 =A0Emacs can display non-JFIF non-Exif JPEG images. > > Then we should perhaps obsolete `image-jpeg-p' (which is not used > anymore in the sources). > > Currently it does what its docstring says, but there's some of a > mismatch with the name (which seems to imply more generality); also it > is not clear what purpose does serve a function to detect just > JFIF/Exif JPEGs. And generalizing it would turn it into a trivial > two-liner. I left `image-jpeg-p' in image.el for the case it's used by some external packages or .emacs files since it contains a non-trivial algorithm for detecting JFIF/Exif JPEGs. Even though its name is not too specific, its docstring explains what it does. --=20 Juri Linkov http://www.jurta.org/emacs/