From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: bookmark.el bug report
Date: Sat, 02 Jan 2010 08:03:47 +0100 [thread overview]
Message-ID: <87ljgh2dkc.fsf@tux.homenetwork> (raw)
In-Reply-To: 87aawx9jfm.fsf@red-bean.com
Karl Fogel <kfogel@red-bean.com> writes:
> Karl Fogel <kfogel@red-bean.com> writes:
>>------------------------------------------------------------
>>revno: 99229
>>revision-id: kfogel@red-bean.com-20100102043617-3bbh6lg62a8ycsa2
>>parent: lekktu@gmail.com-20100102010911-q2hnd1wl2vqgfgb0
>>committer: Karl Fogel <kfogel@red-bean.com>
>>branch nick: trunk
>>timestamp: Fri 2010-01-01 23:36:17 -0500
>>message:
>> * lisp/bookmark.el: Improvements suggested by Drew Adams:
>> (bookmark-bmenu-ensure-position): New name for
>> `bookmark-bmenu-check-position'. Just ensure the position;
>> don't return any meaningful value.
>> (bookmark-bmenu-header-height, bookmark-bmenu-marks-width): New constants.
>
> And if I could edit the commit message for this one, I'd add:
>
> (everywhere): Adjust former callers of `bookmark-bmenu-check-position'
> to call `bookmark-bmenu-ensure-position' instead, and to not use the
> return value.
There is one bug also in bookmark-bmenu-hide-filenames where you forget
to put properties on bookmark when rebuilding.
So after one use of hide-/show-filenames, bookmark-bmenu-bookmark
doesn't work anymore because bookmark have no properties.
I sent a patch to Stefan.
--
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France
next prev parent reply other threads:[~2010-01-02 7:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 6:19 bookmark.el bug report Sun Yijiang
2009-12-28 6:48 ` Karl Fogel
2009-12-28 7:41 ` Thierry Volpiatto
2009-12-28 15:58 ` Drew Adams
2009-12-28 21:12 ` Karl Fogel
2009-12-29 18:22 ` Stefan Monnier
2009-12-30 13:37 ` Thierry Volpiatto
2009-12-30 15:28 ` Stefan Monnier
2009-12-30 15:57 ` Drew Adams
2009-12-30 16:26 ` Drew Adams
2009-12-30 17:43 ` Thierry Volpiatto
2009-12-30 18:32 ` Stefan Monnier
2010-01-02 5:05 ` Karl Fogel
2010-01-02 5:15 ` Karl Fogel
2010-01-02 7:03 ` Thierry Volpiatto [this message]
2010-01-02 7:26 ` Karl Fogel
2010-01-02 8:15 ` Thierry Volpiatto
2010-01-02 19:17 ` Karl Fogel
2010-01-02 7:51 ` Drew Adams
2010-01-02 8:16 ` Karl Fogel
2010-01-02 8:42 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljgh2dkc.fsf@tux.homenetwork \
--to=thierry.volpiatto@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).