From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: visible-bell patch for Mac OS X Date: Sat, 30 Jan 2010 22:34:32 -0500 Message-ID: <87ljffx7zr.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1264908889 23901 80.91.229.12 (31 Jan 2010 03:34:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 Jan 2010 03:34:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Filipe Cabecinhas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 31 04:34:47 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NbQaE-0000Gw-OQ for ged-emacs-devel@m.gmane.org; Sun, 31 Jan 2010 04:34:47 +0100 Original-Received: from localhost ([127.0.0.1]:36542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NbQaE-0000n1-37 for ged-emacs-devel@m.gmane.org; Sat, 30 Jan 2010 22:34:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NbQa8-0000mB-KS for emacs-devel@gnu.org; Sat, 30 Jan 2010 22:34:40 -0500 Original-Received: from [199.232.76.173] (port=47491 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NbQa8-0000lo-9L for emacs-devel@gnu.org; Sat, 30 Jan 2010 22:34:40 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NbQa6-0004Fg-VM for emacs-devel@gnu.org; Sat, 30 Jan 2010 22:34:40 -0500 Original-Received: from pantheon-po34.its.yale.edu ([130.132.50.80]:60369) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NbQa6-0004FU-Pc for emacs-devel@gnu.org; Sat, 30 Jan 2010 22:34:38 -0500 Original-Received: from furry (adsl-99-58-201-143.dsl.wlfrct.sbcglobal.net [99.58.201.143]) (authenticated bits=0) by pantheon-po34.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0V3YY6W030346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 30 Jan 2010 22:34:34 -0500 Original-Received: by furry (Postfix, from userid 1000) id DEB78C05D; Sat, 30 Jan 2010 22:34:32 -0500 (EST) In-Reply-To: (Filipe Cabecinhas's message of "Sat, 30 Jan 2010 13:34:32 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120735 Archived-At: Filipe Cabecinhas writes: > I've made a patch to remove that ugly black rectangle > from=C2=A0ns_ring_bell, when visible-bell is 't. The patch makes Emacs > behave like the X version, inverting the colors of the top and bottom > lines, and bounces the Dock icon once if Emacs is not the frontmost > app (which can be extended to when visible-bell is 'nil, if desired > (just hoist it outside the if). Thanks. Looks good, I've checked it in.