unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: emacs-devel@gnu.org
Subject: Re: pointless buttons at end of VC log buffers
Date: Tue, 16 Feb 2010 14:15:45 +0100	[thread overview]
Message-ID: <87ljetz5ha.fsf@telefonica.net> (raw)
In-Reply-To: buohbph370c.fsf@dhlpc061.dev.necel.com

Miles Bader <miles@gnu.org> writes:

> Óscar Fuentes <ofv@wanadoo.es> writes:
>>> * It seems like it should only show these buttons if the log listing
>>> gets interrupted for some reason.
>>
>> For this, VC-log needs to count how many revisions it is showing and
>> compare with the number of revisions on the branch. Looks like too much
>> work. OTOH, on some backends (i.e. git) it is difficult to differentiate
>> the first (oldest) revision from any other on the log listing, as it
>> lacks revision numbers.
>
> I don't understand this....
>
> The underlying log command outputs all revisions by default, so if it
> didn't output all of them, that must have explicitly been requested by
> emacs, so emacs should know about it.

By default, Emacs asks to the underlying log command to output
`vc-log-show-limit' items, which right now defaults to 2000. However, if
there are less revisions, Emacs would need to detect this circumstance
somehow for knowing that the buttons are of no use.

> [Also, is it supposed to be operating incrementally?  At least with git,
> it just pauses for a while and then outputs the entire log at once.]

AFAIK, it runs asynchronously.





  reply	other threads:[~2010-02-16 13:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16  4:42 pointless buttons at end of VC log buffers Miles Bader
2010-02-16  5:38 ` Óscar Fuentes
2010-02-16  8:43   ` Miles Bader
2010-02-16 13:15     ` Óscar Fuentes [this message]
2010-02-16 13:54       ` Miles Bader
2010-02-16 16:49         ` Stefan Monnier
2010-02-17 22:36           ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ljetz5ha.fsf@telefonica.net \
    --to=ofv@wanadoo.es \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).