* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
[not found] <E1OJgKM-0003iH-Qh@internal.in.savannah.gnu.org>
@ 2010-06-02 13:54 ` Stefan Monnier
2010-06-02 14:07 ` Stephen J. Turnbull
2010-06-02 16:10 ` Dan Nicolaescu
0 siblings, 2 replies; 10+ messages in thread
From: Stefan Monnier @ 2010-06-02 13:54 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: emacs-devel
> * src/dbusbind.c: Use #include <config.h> instead of "config.h" as all
> other files do.
I understand teh desire to make it uniform, but why choose to
standardize on <config.h> rather than "config.h"?
I'd have thought the other one would be a better choice, since <...> is
normally used for system headers and "..." for the program's
own headers.
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
2010-06-02 13:54 ` [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes Stefan Monnier
@ 2010-06-02 14:07 ` Stephen J. Turnbull
2010-06-02 15:25 ` Stefan Monnier
2010-06-02 16:10 ` Dan Nicolaescu
1 sibling, 1 reply; 10+ messages in thread
From: Stephen J. Turnbull @ 2010-06-02 14:07 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Dan Nicolaescu, emacs-devel
Stefan Monnier writes:
> > * src/dbusbind.c: Use #include <config.h> instead of "config.h" as all
> > other files do.
>
> I understand teh desire to make it uniform, but why choose to
> standardize on <config.h> rather than "config.h"?
VPATH.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
2010-06-02 14:07 ` Stephen J. Turnbull
@ 2010-06-02 15:25 ` Stefan Monnier
2010-06-02 16:55 ` Stephen J. Turnbull
0 siblings, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2010-06-02 15:25 UTC (permalink / raw)
To: Stephen J. Turnbull; +Cc: Dan Nicolaescu, emacs-devel
>> > * src/dbusbind.c: Use #include <config.h> instead of "config.h" as all
>> > other files do.
>> I understand teh desire to make it uniform, but why choose to
>> standardize on <config.h> rather than "config.h"?
> VPATH.
I don't see how that relates. VPATH seems to be a make-only feature,
whereas we're talking about C code.
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
2010-06-02 15:25 ` Stefan Monnier
@ 2010-06-02 16:55 ` Stephen J. Turnbull
2010-06-02 19:08 ` Jan Djärv
2010-06-03 9:51 ` Miles Bader
0 siblings, 2 replies; 10+ messages in thread
From: Stephen J. Turnbull @ 2010-06-02 16:55 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Dan Nicolaescu, emacs-devel
Stefan Monnier writes:
> >> > * src/dbusbind.c: Use #include <config.h> instead of "config.h" as all
> >> > other files do.
> >> I understand teh desire to make it uniform, but why choose to
> >> standardize on <config.h> rather than "config.h"?
> > VPATH.
>
> I don't see how that relates. VPATH seems to be a make-only feature,
> whereas we're talking about C code.
Specifically, people who build both in-tree and out-of-tree.
If you do that, VPATH/--srcdir can break because you have multiple
config.h on the #include search path, and the one in-tree always wins
if you use #include "config.h".
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
2010-06-02 16:55 ` Stephen J. Turnbull
@ 2010-06-02 19:08 ` Jan Djärv
2010-06-03 0:34 ` Stephen J. Turnbull
2010-06-03 9:51 ` Miles Bader
1 sibling, 1 reply; 10+ messages in thread
From: Jan Djärv @ 2010-06-02 19:08 UTC (permalink / raw)
To: Stephen J. Turnbull; +Cc: Dan Nicolaescu, Stefan Monnier, emacs-devel
Stephen J. Turnbull skrev 2010-06-02 18.55:
> Stefan Monnier writes:
> > >> > * src/dbusbind.c: Use #include<config.h> instead of "config.h" as all
> > >> > other files do.
> > >> I understand teh desire to make it uniform, but why choose to
> > >> standardize on<config.h> rather than "config.h"?
> > > VPATH.
> >
> > I don't see how that relates. VPATH seems to be a make-only feature,
> > whereas we're talking about C code.
>
> Specifically, people who build both in-tree and out-of-tree.
>
> If you do that, VPATH/--srcdir can break because you have multiple
> config.h on the #include search path, and the one in-tree always wins
> if you use #include "config.h".
I get that once in a while, but if you are building out of the tree you
shouldn't have any config.h in-tree. Unless you mix in and out of tree builds.
Jan D.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
2010-06-02 19:08 ` Jan Djärv
@ 2010-06-03 0:34 ` Stephen J. Turnbull
0 siblings, 0 replies; 10+ messages in thread
From: Stephen J. Turnbull @ 2010-06-03 0:34 UTC (permalink / raw)
To: Jan Djärv; +Cc: Dan Nicolaescu, Stefan Monnier, emacs-devel
Jan Djärv writes:
> I get that once in a while, but if you are building out of the tree
> you shouldn't have any config.h in-tree. Unless you mix in and out
> of tree builds.
Personally, I use out-of-tree builds exclusively. XEmacs consistently
uses '#include <config.h>' because somebody did mix builds, though.
I suspect it's actually a common pattern among new developers (and
Bazaar will contribute to continuing temptation because it's so slow)
to do
tar ...
cd ...
./configure -Oinfinity ...
make
# didn't see *that* coming
mkdir debug-build
cd debug-build
../configure --srcdir=.. -O $DEBUG_OPTIONS ...
make
rather than make a new workspace.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
2010-06-02 16:55 ` Stephen J. Turnbull
2010-06-02 19:08 ` Jan Djärv
@ 2010-06-03 9:51 ` Miles Bader
2010-06-03 13:08 ` Stephen J. Turnbull
1 sibling, 1 reply; 10+ messages in thread
From: Miles Bader @ 2010-06-03 9:51 UTC (permalink / raw)
To: Stephen J. Turnbull; +Cc: Dan Nicolaescu, Stefan Monnier, emacs-devel
"Stephen J. Turnbull" <stephen@xemacs.org> writes:
> Specifically, people who build both in-tree and out-of-tree.
Does anybody actually do that? It's a very bad habit to get into,
because it often doesn't work.
-Miles
--
I'd rather be consing.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
2010-06-03 9:51 ` Miles Bader
@ 2010-06-03 13:08 ` Stephen J. Turnbull
0 siblings, 0 replies; 10+ messages in thread
From: Stephen J. Turnbull @ 2010-06-03 13:08 UTC (permalink / raw)
To: Miles Bader; +Cc: Dan Nicolaescu, Stefan Monnier, emacs-devel
Miles Bader writes:
> "Stephen J. Turnbull" <stephen@xemacs.org> writes:
> > Specifically, people who build both in-tree and out-of-tree.
>
> Does anybody actually do that? It's a very bad habit to get into,
> because it often doesn't work.
I don't know if anybody does it habitually; if they do, problems
haven't been reported where I can see them. I've never had problems
when I do it (not very often, usually by accident or greater than
usual laziness). The exception is when a new file gets an '#include
"config.h"', but that's a bug.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
2010-06-02 13:54 ` [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes Stefan Monnier
2010-06-02 14:07 ` Stephen J. Turnbull
@ 2010-06-02 16:10 ` Dan Nicolaescu
2010-06-03 15:19 ` Richard Stallman
1 sibling, 1 reply; 10+ messages in thread
From: Dan Nicolaescu @ 2010-06-02 16:10 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * src/dbusbind.c: Use #include <config.h> instead of "config.h" as all
>> other files do.
>
> I understand teh desire to make it uniform, but why choose to
> standardize on <config.h> rather than "config.h"?
Just because <config.h> was used in more places and for a longer time.
My own preference would be "config.h", but it looks like the opposite
choice was made a while ago...
> I'd have thought the other one would be a better choice, since <...> is
> normally used for system headers and "..." for the program's
> own headers.
>
>
> Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-06-03 15:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1OJgKM-0003iH-Qh@internal.in.savannah.gnu.org>
2010-06-02 13:54 ` [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes Stefan Monnier
2010-06-02 14:07 ` Stephen J. Turnbull
2010-06-02 15:25 ` Stefan Monnier
2010-06-02 16:55 ` Stephen J. Turnbull
2010-06-02 19:08 ` Jan Djärv
2010-06-03 0:34 ` Stephen J. Turnbull
2010-06-03 9:51 ` Miles Bader
2010-06-03 13:08 ` Stephen J. Turnbull
2010-06-02 16:10 ` Dan Nicolaescu
2010-06-03 15:19 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).