unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Dan Nicolaescu <dann@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: alloca() warnings on freebsd
Date: Tue, 10 Aug 2010 12:38:14 +0300	[thread overview]
Message-ID: <87lj8else1.fsf@kobe.laptop> (raw)
In-Reply-To: yxqmxsv1ini.fsf@fencepost.gnu.org

On Mon, 09 Aug 2010 19:16:33 -0400, Dan Nicolaescu <dann@gnu.org> wrote:
> Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
>> Some time during the recent past an alloca() prototype was introduced to
>> config.h that conflicts with the stdlib.h prototype of alloca() on my
>> FreeBSD laptop.
>>
>> The current check near line 1148 of config.in is:
>>
>>     #ifdef HAVE_ALLOCA_H
>>     # include <alloca.h>
>>     #elif defined __GNUC__
>>     # define alloca __builtin_alloca
>>     #elif defined _AIX
>>     # define alloca __alloca
>>     #else
>>     # include <stddef.h>
>>     # ifdef  __cplusplus
>>     extern "C"
>>     # endif
>>     void *alloca (size_t);
>>     #endif

> What we use now is a shorter version what the autoconf manual
> recommends.  Could you ask the autoconf guys about this, and post the
> solution here?  That would help fix the same problem for other
> programs, not only for emacs.

The manual version is indeed bogus.  It assumes that if __GNUC__ is
defined, then __builtin_alloca() is always ok.  I'll try to contact the
autoconf people.  In the meantime the patch seems to have fixed the
alloca() warnigns on FreeBSD.  I'll keep it in my personal patch queue:

  http://bitbucket.org/keramida/emacs-bsd-patches/src/tip/patch-alloca
  http://bitbucket.org/keramida/emacs-bsd-patches/src/tip/patch-alloca-regen

So when the autoconf people reply I'll followup with more details.

Thanks,
Giorgos




  reply	other threads:[~2010-08-10  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09 22:09 alloca() warnings on freebsd Giorgos Keramidas
2010-08-09 23:16 ` Dan Nicolaescu
2010-08-10  9:38   ` Giorgos Keramidas [this message]
2010-09-07 19:01     ` Giorgos Keramidas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lj8else1.fsf@kobe.laptop \
    --to=keramida@ceid.upatras.gr \
    --cc=dann@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).