unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Christian Millour <cm@abtela.com>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] make shell-process-popd aware of comint-file-name-prefix
Date: Sat, 06 Nov 2010 13:14:00 +0100	[thread overview]
Message-ID: <87lj56abuf.fsf@gmx.de> (raw)
In-Reply-To: <87wroq3mzi.fsf@abtela.com> (Christian Millour's message of "Sat,  06 Nov 2010 08:55:13 +0100")

Christian Millour <cm@abtela.com> writes:

> Hi, 

Hi,

> shell-process-popd (in lisp/shell.el) is currently unaware of
> comint-file-name-prefix. This is inconsistent with the behavior of
> shell-process-pushd and shell-process-cd, and hampers proper directory
> tracking in tramp remote shells (see
> http://lists.gnu.org/archive/html/tramp-devel/2010-11/msg00013.html
> ). The attached patch should correct this oversight. 

Thanks, I've committed your patch. It is less than 15 lines, it can be
regarded as tiny patch, therefore.

> This is my first stab at contributing to emacs so please be patient and
> forgiving if I did not do it right or missed something. 

If you intend to submit further patches to Emacs and/or Tramp, it would
be necessary to register at FSF (and sign the legal papers). Just
contact me in case of.

> Best regards, Christian. 

Best regards, Michael.



      reply	other threads:[~2010-11-06 12:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06  7:55 [patch] make shell-process-popd aware of comint-file-name-prefix Christian Millour
2010-11-06 12:14 ` Michael Albinus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lj56abuf.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=cm@abtela.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).