From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: possible json.el optimization: json-alist-p and json-plist-p recursion Date: Fri, 14 Oct 2011 10:09:40 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87lisnr7ff.fsf@lifelogs.com> References: <877h49t2y8.fsf@lifelogs.com> <87lisoswn9.fsf@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1318601412 32616 80.91.229.12 (14 Oct 2011 14:10:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 14 Oct 2011 14:10:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 14 16:10:08 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1REiSb-0002Hi-G1 for ged-emacs-devel@m.gmane.org; Fri, 14 Oct 2011 16:10:05 +0200 Original-Received: from localhost ([::1]:52535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REiSa-0000x2-AF for ged-emacs-devel@m.gmane.org; Fri, 14 Oct 2011 10:10:04 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:42701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REiSX-0000vx-7M for emacs-devel@gnu.org; Fri, 14 Oct 2011 10:10:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REiSS-000849-O8 for emacs-devel@gnu.org; Fri, 14 Oct 2011 10:10:01 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:40141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REiSS-00083m-I4 for emacs-devel@gnu.org; Fri, 14 Oct 2011 10:09:56 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1REiSR-0002BY-BS for emacs-devel@gnu.org; Fri, 14 Oct 2011 16:09:55 +0200 Original-Received: from c-76-28-40-19.hsd1.vt.comcast.net ([76.28.40.19]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 14 Oct 2011 16:09:55 +0200 Original-Received: from tzz by c-76-28-40-19.hsd1.vt.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 14 Oct 2011 16:09:55 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 41 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-76-28-40-19.hsd1.vt.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux) Cancel-Lock: sha1:bOmF3MFa9hGHAoCDoduDrUkxBuM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:145219 Archived-At: On Thu, 13 Oct 2011 12:07:22 -0400 Ted Zlatanov wrote: TZ> Good points, I had the `car-safe' and `cdr-safe' calls left over from TZ> earlier code, and I was copying into p unnecessarily. This is better, I TZ> think: #+begin_src lisp (defun gnus-sync-json-alist-p (list) "Non-null if and only if LIST is an alist." (while (consp list) (setq list (if (consp (car list)) (cdr list) 'not-alist))) (null list)) (defun gnus-sync-json-plist-p (list) "Non-null if and only if LIST is a plist." (while (consp list) (setq list (if (and (keywordp (car list)) (consp (cdr list))) (cddr list) 'not-plist))) (null list)) #+end_src Emacs Lisp doesn't have `alist-p' or `plist-p' which these functions could provide. So instead of fixing just json.el, can I move these functions to the core and rewrite json.el accordingly? I think that would be useful. But here's why I didn't just do it: these functions are exclusive, meaning they don't accept a general list that has cons cells. So this example list is OK with `assq' but would fail the proposed `alist-p': (assq 1 '((1 . 2) 3)) WDYT? Should I change the name to `[ap]list-pure-p' or something like that? Or is this too limited to be generally useful? Thanks Ted