unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Recent keyboard changes breaks quitting
Date: Sat, 22 Sep 2012 22:51:20 +0800	[thread overview]
Message-ID: <87lig22jrr.fsf@gnu.org> (raw)

Hi Eli, somehow your latest changes to keyboard.c broke quitting:

M-x C-g
  => The cursor remains in the minibuffer.

A second C-g is needed to exit the minibuffer.
I verified that this behavior was introduced by

  revno: 110138
  fixes bugs: http://debbugs.gnu.org/12447 http://debbugs.gnu.org/12326
  committer: Eli Zaretskii <eliz@gnu.org>
  branch nick: trunk
  timestamp: Sat 2012-09-22 16:16:03 +0300
  message:
  Fix bugs #12447 and #12326 with infloop causes by idle timers, update docs.

  src/keyboard.c (timer_check_2): Move calculation of 'timers' and
  'idle_timers' from here ...
  (timer_check): ... to here.  Use Fcopy_sequence to copy the timer
  lists, to avoid infloops when the timer does something stupid,
  like reinvoke itself with the same or smaller time-out.

  lisp/emacs-lisp/timer.el (run-with-idle-timer)
  (timer-activate-when-idle): Warn against reinvoking an idle timer
  from within its own timer action.

  doc/lispref/os.texi (Idle Timers): Warn against reinvoking an idle timer
  from within its own timer action.



             reply	other threads:[~2012-09-22 14:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-22 14:51 Chong Yidong [this message]
2012-09-22 16:11 ` Recent keyboard changes breaks quitting Eli Zaretskii
2012-09-22 17:20   ` Chong Yidong
2012-09-22 17:29     ` Jan Djärv
2012-09-22 17:35     ` Chong Yidong
2012-09-22 18:56       ` Eli Zaretskii
2012-09-22 19:06         ` Eli Zaretskii
2012-09-23  2:53         ` Chong Yidong
2012-09-23  4:01           ` Eli Zaretskii
2012-09-23  6:05             ` Chong Yidong
2012-09-23  8:33               ` Chong Yidong
2012-09-23 16:50                 ` Eli Zaretskii
2012-09-22 19:27       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lig22jrr.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).