From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: trunk r116456: Improve dbus performance on synchronous calls Date: Mon, 17 Feb 2014 17:06:37 +0100 Message-ID: <87lhx9lo4y.fsf@gmx.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1392653221 10036 80.91.229.3 (17 Feb 2014 16:07:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Feb 2014 16:07:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 17 17:07:08 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WFQih-0002RU-JJ for ged-emacs-devel@m.gmane.org; Mon, 17 Feb 2014 17:06:59 +0100 Original-Received: from localhost ([::1]:42363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFQig-0000b8-WA for ged-emacs-devel@m.gmane.org; Mon, 17 Feb 2014 11:06:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFQiY-0000XL-0k for emacs-devel@gnu.org; Mon, 17 Feb 2014 11:06:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFQiQ-0000gx-JC for emacs-devel@gnu.org; Mon, 17 Feb 2014 11:06:49 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:64352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFQiQ-0000gV-Ao for emacs-devel@gnu.org; Mon, 17 Feb 2014 11:06:42 -0500 Original-Received: from detlef.gmx.de ([93.209.82.193]) by mail.gmx.com (mrgmx002) with ESMTPS (Nemesis) id 0LngNT-1WwBJw43Vn-00htYn for ; Mon, 17 Feb 2014 17:06:40 +0100 In-Reply-To: (Daniel Colascione's message of "Mon, 17 Feb 2014 11:42:00 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:EztDgJ2H+N5SHXFAyzWpeZT+B+cK5lxbh7MnUNoLpA6+6cRKuQy lz/46Nzv+TlOg0YTaRXfvViuSTdRHTCjn7UNMN2sTP/x8GuPszAvBWlJsL7zxkxlZh5o9ot 31NSkHNPheMkQrYt99xEKKfDLwpihrgzvo6mvlwhOldhGes8Bw4XawalZp80qVGJvxkH+6K dOa/cljFepLi10bMzyfdw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169696 Archived-At: Daniel Colascione writes: > (with-timeout ((if timeout (/ timeout 1000.0) 25)) > (while (eq (gethash key dbus-return-values-table :ignore) :ignore) > - (let ((event (let ((inhibit-redisplay t) unread-command-events) > - (read-event nil nil 0.1)))) > - (when (and event (not (ignore-errors (dbus-check-event event)))) > - (setq unread-command-events > - (append unread-command-events (list event))))))) > + (let ((event (let ((inhibit-redisplay t) unread-command-events) > + (read-event nil nil check-interval)))) > + (when event > + (push event unread-command-events)) > + (when (< check-interval 1) > + (setf check-interval (* check-interval 1.05)))))) Why `push'? It adds the event on top of `unread-command-events', changing the event order when there are already events in that list. Best regards, Michael.