unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mario Lang <mlang@delysid.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] eww-mode-map doesn't bind TAB on tty.
Date: Wed, 05 Mar 2014 16:02:54 +0100	[thread overview]
Message-ID: <87lhwor8m9.fsf@fx.delysid.org> (raw)
In-Reply-To: <87d2i0zund.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Wed, 05 Mar 2014 13:39:50 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> [tab] is a function key, not the character TAB.  Try ?\t instead.
>>
>> And [?\M-\t] for backtab.
>
> Right; thanks.

`eww-text-map', `eww-textarea-map' and `shr-map' likely have the same
problem as `eww-mode-map' used to have:

--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -592,8 +592,8 @@ appears in a <link> or <a> tag."
     (define-key map [(control a)] 'eww-beginning-of-text)
     (define-key map [(control c) (control c)] 'eww-submit)
     (define-key map [(control e)] 'eww-end-of-text)
-    (define-key map [tab] 'shr-next-link)
-    (define-key map [backtab] 'shr-previous-link)
+    (define-key map [?\t] 'shr-next-link)
+    (define-key map [?\M-\t] 'shr-previous-link)
     map))
 
 (defvar eww-textarea-map
@@ -601,8 +601,8 @@ appears in a <link> or <a> tag."
     (set-keymap-parent map text-mode-map)
     (define-key map "\r" 'forward-line)
     (define-key map [(control c) (control c)] 'eww-submit)
-    (define-key map [tab] 'shr-next-link)
-    (define-key map [backtab] 'shr-previous-link)
+    (define-key map [?\t] 'shr-next-link)
+    (define-key map [?\M-\t] 'shr-previous-link)
     map))
 
 (defvar eww-select-map
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -147,8 +147,8 @@ cid: URL as the argument.")
     (define-key map "a" 'shr-show-alt-text)
     (define-key map "i" 'shr-browse-image)
     (define-key map "z" 'shr-zoom-image)
-    (define-key map [tab] 'shr-next-link)
-    (define-key map [backtab] 'shr-previous-link)
+    (define-key map [?\t] 'shr-next-link)
+    (define-key map [?\M-\t] 'shr-previous-link)
     (define-key map [follow-link] 'mouse-face)
     (define-key map [mouse-2] 'shr-browse-url)
     (define-key map "I" 'shr-insert-image)


And here is the result of grepping for the pattern in all Emacs Lisp files:

lisp/calendar/todo-mode.el:    (define-key map [tab] 'todo-next-button)
lisp/eshell/em-cmpl.el:  (define-key eshell-command-map [tab] 'pcomplete-expand-and-complete)
lisp/eshell/em-cmpl.el:  (define-key eshell-mode-map [tab] 'eshell-pcomplete)
lisp/gnus/gnus-html.el:    (define-key map [tab] 'widget-forward)
lisp/image-dired.el:  (define-key image-dired-thumbnail-mode-map [tab] 'image-dired-jump-original-dired-buffer)
lisp/image-dired.el:  (define-key dired-mode-map [tab] 'image-dired-jump-thumbnail-buffer)
lisp/international/quail.el:    (define-key map [tab] 'quail-completion)
lisp/kmacro.el:    (define-key map [tab] 'act-repeat)
lisp/play/5x5.el:    (define-key map [tab]                     #'5x5-right)

-- 
CYa,
  ⡍⠁⠗⠊⠕



  reply	other threads:[~2014-03-05 15:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 12:37 [PATCH] eww-mode-map doesn't bind TAB on tty Mario Lang
2014-03-04 19:39 ` Lars Ingebrigtsen
2014-03-04 20:07   ` Eli Zaretskii
2014-03-04 20:13     ` Eli Zaretskii
2014-03-05 12:39       ` Lars Ingebrigtsen
2014-03-05 15:02         ` Mario Lang [this message]
2014-03-05 17:18           ` Eli Zaretskii
2014-03-05 18:01           ` Lars Ingebrigtsen
2014-03-05 18:10             ` Lars Ingebrigtsen
2014-03-05 18:37               ` Eli Zaretskii
2014-03-05 18:39                 ` Lars Ingebrigtsen
2014-03-07 20:12                   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhwor8m9.fsf@fx.delysid.org \
    --to=mlang@delysid.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).