From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 8aa0386: Add seq-find Date: Sun, 13 Sep 2015 16:09:13 +0200 Message-ID: <87lhcaxvg6.fsf@petton.fr> References: <20150910221007.23863.13601@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1442153382 2458 80.91.229.3 (13 Sep 2015 14:09:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Sep 2015 14:09:42 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 13 16:09:28 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zb7yB-0006r7-R1 for ged-emacs-devel@m.gmane.org; Sun, 13 Sep 2015 16:09:27 +0200 Original-Received: from localhost ([::1]:35996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zb7yB-0003fP-Ee for ged-emacs-devel@m.gmane.org; Sun, 13 Sep 2015 10:09:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zb7y7-0003f7-Ag for emacs-devel@gnu.org; Sun, 13 Sep 2015 10:09:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zb7y2-0002RY-Ci for emacs-devel@gnu.org; Sun, 13 Sep 2015 10:09:23 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zb7y2-0002R4-97 for emacs-devel@gnu.org; Sun, 13 Sep 2015 10:09:18 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 884E720479 for ; Sun, 13 Sep 2015 10:09:16 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 13 Sep 2015 10:09:16 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=S2zYZRy7p5AT5U9uuL+5iLTghCs=; b=dSv7Q HBQBvJYtnQUecPM+hBEnhH9u6yhmiLd4Pne/ni47gLwKdDYNczg1AuM/aVwjA8xj Epy7CWFQVPBKLkWjJyfRFW6O2In44MDeGJaRX08FSLVdP3+CB9Ka5ZQiCDWCgIAr cH3WufjOF8lrw4Sk/3kcHUGz94nsBCq7cXDCjw= X-Sasl-enc: wtHssLIxr/ZVXsUz/gEt7k1PNVcnaKpOzg408+vuR801 1442153356 Original-Received: from blueberry (arennes-658-1-183-218.w92-139.abo.wanadoo.fr [92.139.0.218]) by mail.messagingengine.com (Postfix) with ESMTPA id C9ACC6800B4; Sun, 13 Sep 2015 10:09:15 -0400 (EDT) In-Reply-To: User-Agent: Notmuch/0.19 (http://notmuchmail.org) Emacs/25.0.50.5 (x86_64-unknown-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189891 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stefan Monnier writes: >> + "Return the first element for which (PRED element) is non-nil in SEQ. >> +If no element is found, return SENTINEL or nil. > > "return SENTINEL or nil" should be just "return SENTINEL". > > Not only it's shorter, but it's also more precise (the current text > doesn't say when it returns SENTINEL and when it returns nil). > >> +Note that `seq-find' has an ambiguity if the found element is nil >> +and if no SENTINEL is specified, as it cannot be known if an >> +element was found or not." > > It's not just for nil but for the case where the found value is > identical to SENTINEL. Thanks, I'll improve the docstring. Nico =2D-=20 Nicolas Petton http://nicolas-petton.fr --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: GPGTools - http://gpgtools.org iQEcBAEBCAAGBQJV9YOJAAoJECM1h6R8IHkQsn8H/2/JcNay10BHTJXFvqZ33ABj SKtahUtha925UPgvMj5xxPe50dcuN0/Snsq76FUTqAypXX+1Sn+OEaJwUbbSzZOH vo5iwUxl0rQQiL8cr25A6OD3Hw7g0wF0+/g+3ZAHS7es7tVYijr9IwIJc4kdAcpR kXFIUKJM+kGNYQFQqj0aCc0Ub2FHer50lR7r+C5X59Wp1H9/RccED+Lx57KlDepn 6ewCRqly0kkDaT/NlSraFRb5ARLQrzKCey/kO3RyZAk+YhyGymtFtpFUG0o16/Fj AJT2TBO+vD/D1Zkh6SGEyJUVkkrLBP9+Y7kqmAOLdpnriQXKJ+3lhnNR9rN3aVg= =oVXV -----END PGP SIGNATURE----- --=-=-=--