Re: master e870279 1/2: Quick temporary hack to fix curcell refreshing.

Re: master e870279 1/2: Quick temporary hack to fix curcell refreshing.

[Óscar Fuentes]

Please install bugfixes on the emacs-25  branch.

Your change addresses bug#21054, which is a release blocker.

Vincent Belache <vincentb1@users.sourceforge.net> writes:

> branch: master
> commit e8702794d46ae032803bf54ffbd71ebde215179c
> Author: Vincent Belaïche <vincentb1@users.sourceforge.net>
> Commit: Vincent Belaïche <vincentb1@users.sourceforge.net>
>
>     Quick temporary hack to fix curcell refreshing.
>     
>     The problem was caused by change: 2015-04-13 Deprecate `intangible'
>     and `point-entered' properties. The problem is that this change has
>     removed the (setq ses--curcell t) setting in the ses-command-hook
>     function.
>     
>     * ses.el (ses-check-curcell): replace `(eq ses--curcell t)' by just `t' as
>     a condition to call function `ses-set-curcell'. Comment this as a quick
>     temporary hack to make it work, as I don't know yet whether a definite
>     correction would be to make the ses-set-curcell at every ses-check-curcell,
>     or to revert to the previous approach, ie marking ses--curcell as out-of-date
>     at every potentially cursor motion command.
> ---
>  lisp/ses.el |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/ses.el b/lisp/ses.el
> index ec1359b..7347eb8 100644
> --- a/lisp/ses.el
> +++ b/lisp/ses.el
> @@ -1117,7 +1117,11 @@ region, or nil if cursor is not at a cell."
>  The end marker is appropriate if some argument is 'end.
>  A range is appropriate if some argument is 'range.
>  A single cell is appropriate unless some argument is 'needrange."
> -  (if (eq ses--curcell t)
> +  (if t;; Vincent B.:
> +      ;; previously (eq ses--curcell t)
> +      ;; this is a quick hack to temporary fix the bug implied by changes made by Stefan in
> +      ;; http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ses.el?id=84e0b7dad6f1a8e53261f9b96f5a9080fea681a4
> +      ;;-------------------------------------------------------------------------
>        ;; curcell recalculation was postponed, but user typed ahead.
>        (ses-set-curcell))
>    (cond
>
> _______________________________________________
> Emacs-diffs mailing list
> Emacs-diffs@gnu.org
> https://lists.gnu.org/mailman/listinfo/emacs-diffs

Re: master e870279 1/2: Quick temporary hack to fix curcell refreshing.

[Vincent Belaïche]

Dear Óscar,

I will do that ASAP. I think that it is desirable also to make the same
correction as

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0c9abf36a4fbc775918c08c1104a64d037280abc

titled "Correct ses-rename-cell cursor-intangible text prop updating."

That was a hidden bug that had remained unoticed to me up to
now. However, after the changes made by Stefan on 2015-04-13T19:51:15Z
(Deprecate `intangible' and `point-entered' properties), this became a
nuisance every time you rename a cell --- so maybe not so big a
nuisance, if you don't use cell renaming.

FYI, renamed cells still need some work to be fully functional (notably
for not relocating their name after some column/row insertion), but I
will do that on the master branch only.

VBR,
    Vincent



Le 30/12/2015 18:38, Óscar Fuentes a écrit :



  Please install bugfixes on the emacs-25  branch.

Your change addresses bug#21054, which is a release blocker.

Vincent Belache <vincentb1@users.sourceforge.net> writes:


  branch: master
commit e8702794d46ae032803bf54ffbd71ebde215179c
Author: Vincent Belaïche <vincentb1@users.sourceforge.net>
Commit: Vincent Belaïche <vincentb1@users.sourceforge.net>

    Quick temporary hack to fix curcell refreshing.
    
    The problem was caused by change: 2015-04-13 Deprecate `intangible'
    and `point-entered' properties. The problem is that this change has
    removed the (setq ses--curcell t) setting in the ses-command-hook
    function.
    
    * ses.el (ses-check-curcell): replace `(eq ses--curcell t)' by just `t' as
    a condition to call function `ses-set-curcell'. Comment this as a quick
    temporary hack to make it work, as I don't know yet whether a definite
    correction would be to make the ses-set-curcell at every ses-check-curcell,
    or to revert to the previous approach, ie marking ses--curcell as out-of-date
    at every potentially cursor motion command.
---
 lisp/ses.el |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/lisp/ses.el b/lisp/ses.el
index ec1359b..7347eb8 100644
--- a/lisp/ses.el
+++ b/lisp/ses.el
@@ -1117,7 +1117,11 @@ region, or nil if cursor is not at a cell."
 The end marker is appropriate if some argument is 'end.
 A range is appropriate if some argument is 'range.
 A single cell is appropriate unless some argument is 'needrange."
-  (if (eq ses--curcell t)
+  (if t;; Vincent B.:
+      ;; previously (eq ses--curcell t)
+      ;; this is a quick hack to temporary fix the bug implied by changes made by Stefan in
+      ;; http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ses.el?id=84e0b7dad6f1a8e53261f9b96f5a9080fea681a4
+      ;;-------------------------------------------------------------------------
       ;; curcell recalculation was postponed, but user typed ahead.
       (ses-set-curcell))
   (cond

_______________________________________________
Emacs-diffs mailing list
Emacs-diffs@gnu.org
https://lists.gnu.org/mailman/listinfo/emacs-diffs