unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 f5c762c: Additional changes for "make check-expensive"
Date: Tue, 12 Jan 2016 20:03:42 +0100	[thread overview]
Message-ID: <87lh7uwrg1.fsf@gmx.de> (raw)
In-Reply-To: <87io2y66dl.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 12 Jan 2016 17:43:18 +0000")

phillip.lord@russet.org.uk (Phillip Lord) writes:

> Michael

Hi Philip,

> I think that there is a problem with this commit, in that the default
> selector is only used for "make check". By default "make check-maybe"
> runs all tests (including the expensive ones). So, you have to do
>
> make check-maybe SELECTOR="(quote (not (tag :expensive-test)))"
>
> I think it makes more sense for check-maybe to skip expensive tests,
> unless told otherwise, as "make check-maybe" is a good candidate for use
> pre-commit.

I see. Before touching the Makefile, we shall agree how all the targets
shall behave. I would say, that "check" and "check-maybe" shall skip the
expensive tests. "check-expensive", "<foo>", and "<foo>.log" shall run
all tests.

> Phil

Best regards, Michael.



  parent reply	other threads:[~2016-01-12 19:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160105084751.30334.99051@vcs.savannah.gnu.org>
     [not found] ` <E1aGNHT-0007u5-Su@vcs.savannah.gnu.org>
2016-01-12 17:43   ` [Emacs-diffs] emacs-25 f5c762c: Additional changes for "make check-expensive" Phillip Lord
2016-01-12 17:49     ` John Wiegley
2016-01-12 18:55       ` Michael Albinus
2016-01-14 22:15         ` Phillip Lord
2016-01-12 19:03     ` Michael Albinus [this message]
2016-01-14  8:13       ` Michael Albinus
2016-01-14 23:04       ` Phillip Lord
2016-01-15  8:45         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh7uwrg1.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=phillip.lord@russet.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).