unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: emacs-devel@gnu.org
Subject: Re: Bisecting display bugs
Date: Mon, 11 Jul 2016 19:46:42 +0200	[thread overview]
Message-ID: <87lh18awzh.fsf@wanadoo.es> (raw)
In-Reply-To: 837fcsdzkj.fsf@gnu.org

Eli Zaretskii <eliz@gnu.org> writes:

[snip]

>> +Some caveats:
>> +
>> +- This script cleans Emacs' source directory with ‘git clean -xfd’, so
>> +  make sure your uncommitted changes are saved somewhere else.
>
> While bootstrapping after each step of bisect is safe, it makes the
> run much longer, so I'd try bisecting without a bootstrap first,
> especially if the range of commits to bisect is relatively small.

Although that sounds good in principle, my experience tells me that
taking the short path does waste more time than it saves on this case.
YMMV, but too many times the bisection stopped with a build failure that
wouldn't happen with bootstrap, or simply gave wrong results because the
build didn't work correctly.

Speaking of this, the sample script could offer bug failure detection
and `git bisect skip'.

[snip]

>>                                              but some are only
>> +apparent through visual inspection.  Since building Emacs takes a long
>> +time, it can be a pain to debug these manually.
>
> I don't follow this logic: building is an automated process, while
> visual inspection is usually very fast; the automated comparison
> you are about to suggest doesn't decrease the build time.  So how does
> the conclusion follow?

Because I have to be there in front of the terminal. And I can make
mistakes. Anything that makes the bisection automatic is a big
advantage.

[snip]




  reply	other threads:[~2016-07-11 17:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 23:55 Bisecting display bugs Clément Pit--Claudel
2016-07-11  1:40 ` Óscar Fuentes
2016-07-11 14:22 ` Eli Zaretskii
2016-07-11 17:46   ` Óscar Fuentes [this message]
2016-07-11 17:54     ` Eli Zaretskii
2016-07-11 18:05       ` Óscar Fuentes
2016-07-22 18:55   ` Clément Pit--Claudel
2016-07-23  8:51     ` Eli Zaretskii
2016-07-23 13:22       ` Clément Pit--Claudel
2017-04-16 15:04         ` Clément Pit--Claudel
2017-04-16 15:32           ` Noam Postavsky
2017-04-16 20:57             ` Clément Pit-Claudel
2017-04-17 13:13               ` Herring, Davis
2017-04-17 13:43                 ` Teemu Likonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh18awzh.fsf@wanadoo.es \
    --to=ofv@wanadoo.es \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).