From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] checking eww download directory Date: Sat, 28 Jan 2017 15:14:14 +0100 Message-ID: <87lgtv6zm1.fsf@mouse> References: <87wpdgmi84.fsf@udel.edu> <87inp08g2b.fsf@mouse> <20170127194816.GA18966@holos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485612913 26040 195.159.176.226 (28 Jan 2017 14:15:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 14:15:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 28 15:15:08 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXTmO-0005XL-F1 for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 15:15:00 +0100 Original-Received: from localhost ([::1]:52024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXTmS-0002iD-3c for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 09:15:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXTls-0002i8-TV for emacs-devel@gnu.org; Sat, 28 Jan 2017 09:14:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXTlp-0000bf-Mm for emacs-devel@gnu.org; Sat, 28 Jan 2017 09:14:28 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:43561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXTlp-0000ad-Gl for emacs-devel@gnu.org; Sat, 28 Jan 2017 09:14:25 -0500 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cXTlf-0007cS-EP; Sat, 28 Jan 2017 15:14:17 +0100 In-Reply-To: <20170127194816.GA18966@holos.localdomain> (Mark Oteiza's message of "Fri, 27 Jan 2017 14:48:16 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211690 Archived-At: Mark Oteiza writes: > I just went off of knowing it's called Downloads in windows, and trying > to consider plural/nonplural and case insensitivity on Linux. Mine, for > instance is just lower cased. So... the cl-some is probably overkill. I think it's a good idea to try to find the "downloads" directory on the host system, but I think this should be factored out into its own function, so that we can use it in similar circumstances elsewhere. Or perhaps there aren't any other directories like that? Hm... well, "documents", perhaps, and "desktop"... >> > + (access-file eww-download-directory "Download failed") >> >> Seem OK, except that the error message should say what the error is >> instead of this. > > It does, access-file appends the error: > > Download failed: No such file or directory, ~/NOWOAIWJD Oh, cool. Perhaps this line from the doc string could be clearer: "The second argument STRING is used in the error message." -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no