unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Mark Oteiza <mvoteiza@udel.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] checking eww download directory
Date: Sat, 28 Jan 2017 15:14:14 +0100	[thread overview]
Message-ID: <87lgtv6zm1.fsf@mouse> (raw)
In-Reply-To: <20170127194816.GA18966@holos.localdomain> (Mark Oteiza's message of "Fri, 27 Jan 2017 14:48:16 -0500")

Mark Oteiza <mvoteiza@udel.edu> writes:

> I just went off of knowing it's called Downloads in windows, and trying
> to consider plural/nonplural and case insensitivity on Linux.  Mine, for
> instance is just lower cased.  So... the cl-some is probably overkill.

I think it's a good idea to try to find the "downloads" directory on the
host system, but I think this should be factored out into its own
function, so that we can use it in similar circumstances elsewhere.  

Or perhaps there aren't any other directories like that?  Hm...  well,
"documents", perhaps, and "desktop"...

>> > +  (access-file eww-download-directory "Download failed")
>> 
>> Seem OK, except that the error message should say what the error is
>> instead of this.
>
> It does, access-file appends the error:
>
>   Download failed: No such file or directory, ~/NOWOAIWJD

Oh, cool.  Perhaps this line from the doc string could be clearer:

"The second argument STRING is used in the error message."

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  parent reply	other threads:[~2017-01-28 14:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 19:10 [PATCH] checking eww download directory Mark Oteiza
2017-01-27 19:21 ` Lars Ingebrigtsen
2017-01-27 19:48   ` Mark Oteiza
2017-01-27 20:10     ` Eli Zaretskii
2017-01-28  8:01       ` Yuri Khan
2017-01-28  8:54         ` Eli Zaretskii
2017-01-28 14:14     ` Lars Ingebrigtsen [this message]
2017-01-28 21:04       ` Mark Oteiza
2017-01-27 19:27 ` Lars Ingebrigtsen
2017-01-27 19:38 ` Clément Pit-Claudel
2017-01-27 20:17   ` Mark Oteiza
2017-01-27 22:21     ` Clément Pit-Claudel
2017-01-28  7:53     ` Eli Zaretskii
2017-01-29  1:01       ` Library for XDG things (was Re: [PATCH] checking eww download directory) Mark Oteiza
2017-01-30 14:40         ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgtv6zm1.fsf@mouse \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=mvoteiza@udel.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).