From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: rename STRING_SET_CHARS to STRING_SET_SIZE Date: Mon, 17 Apr 2017 12:34:34 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87lgqzuh5x.fsf@lifelogs.com> References: <83a89gq3us.fsf@gnu.org> <87bmtjiv0w.fsf_-_@lifelogs.com> <83o9xjn06c.fsf@gnu.org> <87shmeb5ln.fsf_-_@lifelogs.com> <83y3w5z1ez.fsf@gnu.org> <87lgr6yakj.fsf@lifelogs.com> <87wpamww9k.fsf@lifelogs.com> <8337daggnj.fsf@gnu.org> <87d1cdwxt6.fsf@lifelogs.com> <83tw5pg1q3.fsf@gnu.org> <87zifhulc2.fsf@lifelogs.com> <87vaq3uipz.fsf_-_@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492446924 12889 195.159.176.226 (17 Apr 2017 16:35:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 16:35:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 18:35:20 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d09cT-0003BH-Hl for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 18:35:17 +0200 Original-Received: from localhost ([::1]:37779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d09cY-0007TO-Oo for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 12:35:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d09bu-00073h-0Y for emacs-devel@gnu.org; Mon, 17 Apr 2017 12:34:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d09bt-0002hP-7N for emacs-devel@gnu.org; Mon, 17 Apr 2017 12:34:42 -0400 Original-Received: from [195.159.176.226] (port=50277 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d09bt-0002go-1r for emacs-devel@gnu.org; Mon, 17 Apr 2017 12:34:41 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d09bl-0002RW-IU for emacs-devel@gnu.org; Mon, 17 Apr 2017 18:34:33 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 20 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:x/iYEP8RSx/KyhUib6LT0NoUAqM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214076 Archived-At: On Mon, 17 Apr 2017 12:29:11 -0400 Stefan Monnier wrote: >> Eli, anyone else, is it OK to do that renaming of STRING_SET_CHARS to >> STRING_SET_SIZE? It's a small thing but annoys me :) SM> That macro is only meant to change the number of chars in a string SM> without changing the number of bytes, so the current name doesn't sound SM> bad to me. On Mon, 17 Apr 2017 19:24:28 +0300 Eli Zaretskii wrote: EZ> It is called STRING_SET_CHARS because it sets the same member that EZ> SCHARS returns. And CHARS is actually correct, because the 'size' EZ> member counts string characters (as opposed to bytes). So I don't EZ> think there's a problem with the name here, you just need ti get used EZ> to thinking about it as 'chars', not 'size'. All right, leaving this alone. Thanks for explaining. Ted