From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: How to block tests on hydra Date: Wed, 12 Jul 2017 14:54:45 +0200 Message-ID: <87lgnterxm.fsf@detlef> References: <87y3s8wf6k.fsf@detlef> <877ezffnhv.fsf@detlef> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499864515 2276 195.159.176.226 (12 Jul 2017 13:01:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Jul 2017 13:01:55 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 12 15:01:44 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVHGu-0008IY-LN for ged-emacs-devel@m.gmane.org; Wed, 12 Jul 2017 15:01:40 +0200 Original-Received: from localhost ([::1]:52626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVHH0-0000VD-0O for ged-emacs-devel@m.gmane.org; Wed, 12 Jul 2017 09:01:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVHAU-00045A-K3 for emacs-devel@gnu.org; Wed, 12 Jul 2017 08:55:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVHAP-0007WN-Qz for emacs-devel@gnu.org; Wed, 12 Jul 2017 08:55:02 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:62450) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVHAP-0007Uq-Fq for emacs-devel@gnu.org; Wed, 12 Jul 2017 08:54:57 -0400 Original-Received: from detlef.gmx.de ([213.220.147.117]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Leux5-1e12oj29F9-00qgt9; Wed, 12 Jul 2017 14:54:46 +0200 X-Provags-ID: V03:K0:CuuXcAFj0HiyxkENihNN3Kgs4ZjJ8ZcBaa5frQTv0iHyEjPpOQa KfJQ33iYX3/siU4bHLx66qsSGeHrjWFp4MDrJw++st8GR9XzlU9mx19v9sm1aMnLflKvVsd U1CVW91Kf/rJzxawc6uZU3gNd1mzL+CGjPaIIRNWF3ec8QnUHMS5ka//ky+v54Lnn+1VcLJ U5odwBwCeh1PXMomVWmzA== X-UI-Out-Filterresults: notjunk:1;V01:K0:SKNcZUQknGI=:rvleLw4NQJDIbz7K99NSJB PLekTxSGFHh7DuiFMGtlspBT2Zpke/qP/LbScuuyqBouieLYTXWSklYwE52AuEwZZqKwKgHP+ LD7fGDBtPJX3VwXh3rXdNO3D54mP6mzY/8TYes/GoKOsAS9vSkQQLfKOSOaIfd8WK8gKSxzf5 9f/rdBnrU4HMdKfkUJPGuZTuhJihV2/BSUgB8IQ/lkPOjFXGMv3zbOqYHu5nwyQ74+l2RkauP +y8F7wrFmVaDDxVha+ivzPQoO6Qv6qx1r7fy9vi44vzghSsd5S+9qofJoZTemx9y3ljKCkJ5X cvHD74sYSOPAQZPb15StoK1mRvQezQss13A4d5dQOTKTblASFHiePy41RdQ3mA+J6wO5cBcSE UwykoSKDxXv0CJKMEc9Yr0P6H7nh3LFB6rZheupFGeKQMAZX+smAfJarTBdR+6iqEcNr3caqu G9xfG33AlYa7Aq+FsLyltMHR6xEJ6Hl6ZyEHGvDjj00vL9jiwLOXPEURXsGE8gYy21ZEkOS/O 7dXlBzpocoO2FrMR2OtqiPUBOK44jXAykbGCvN4TUyXXmd5poRVd4gLvFx1oxFkYUnf3OZtDw ZJ8vpz761EcCpjm5az61ToBlaA6DK9xjxkVd0OWs5x45zkE90ZinAJ8dqf/dh8+8VUcqCJ49q wU/n2145R/RC0at2rEqefeUhXwi7xtV/DZpsAXjP5UVbuSnup6LMX8LU22kUN0ZThQWyWvQVb vVx54QkBRnmp+4hckP+DxzDLP8V2bBsHXZK/u/6bg6clqq8T7tYn/WrKVEd+MI3Isr/tnvfM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216529 Archived-At: Noam Postavsky writes: Hi Noam, >>> I'm surprised it does anything at all actually, isn't the (add-to-list >>> 'buffers ...) call a bug? Should be using `push' I think. >>> >>> - (add-to-list 'buffers (generate-new-buffer "foo"))) >>> + (push (generate-new-buffer "foo") buffers)) >> >> Why that? `add-to-list' is as good as `push' in this case. I haven't seen a >> problem with that. If you run in edebug, you'll see that `buffers' keeps >> all process buffers. > > But you have lexical-binding:t set at the top of the file, and > `buffer' is a let-bound variable, whereas `add-to-list' operates on > dynamic variables. Hmm, looking at the disassembly it seems that > add-to-list's compiler macro fixed up the problem, although I thought > it should give a compile warning in this situation. Well, as compromise I use now (setq buffers (cons (generate-new-buffer "foo") buffers)) >>> I noticed you added a with-timeout on that test, but it doesn't seem >>> to be working. >> >> The timeout is a self-defense. And it doesn't trigger at least for me, >> because (I believe) the test case is working properly now, and finishes >> in time. > > What about this one: > > http://hydra.nixos.org/eval/1373949 > https://nix-cache.s3.amazonaws.com/log/v7ndmrhdhjw76v9mzghjyijnsmw2npl8-emacs-coverage-unknown.drv Hmm, it happens sporadically. I have enabled traces for tramp-tests, hopefully we'll get more information when it happens next time. >>> By the way, I hit the "`tramp-test36-asynchronous-requests' timed out" >>> message when running locally in an -O0 build, although it succeeds >>> with an -O2 build. Maybe I just have a weak CPU. Could you try to reproduce it? tramp-tests.log might help then. Best regards, Michael.