From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: Tino Calancha <tino.calancha@gmail.com>
Subject: Re: master 51c8369: Run secrets suite test when Emacs has dbus support
Date: Fri, 06 Apr 2018 09:25:22 +0200 [thread overview]
Message-ID: <87lge07q59.fsf@gmx.de> (raw)
In-Reply-To: <20180406000308.94E77206AB@vcs0.savannah.gnu.org> (Tino Calancha's message of "Thu, 5 Apr 2018 20:03:07 -0400 (EDT)")
tino.calancha@gmail.com (Tino Calancha) writes:
Hi Tino,
> Run secrets suite test when Emacs has dbus support
>
> * test/lisp/net/secrets-tests.el (secrets-test00-availability)
> (secrets-test01-sessions, secrets-test02-collections)
> (secrets-test03-items, secrets-test04-search): Skip test
> unless Emacs is compiled with dbus support.
Why this? If there is no D-Bus support, secrets-enabled shall be nil,
and the tests shall skip (except secrets-test00-availability, which
shall fail). That's intended.
> (ert-deftest secrets-test00-availability ()
> "Test availability of Secret Service API."
> + (skip-unless (featurep 'dbusbind))
> :expected-result (if secrets-enabled :passed :failed)
> (should secrets-enabled)
> (should (dbus-ping :session secrets-service))
FTR, this would be wrong. :expected-result must always be the first
clause in body.
Best regards, Michael.
next parent reply other threads:[~2018-04-06 7:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180406000306.5540.34428@vcs0.savannah.gnu.org>
[not found] ` <20180406000308.94E77206AB@vcs0.savannah.gnu.org>
2018-04-06 7:25 ` Michael Albinus [this message]
2018-04-06 7:36 ` master 51c8369: Run secrets suite test when Emacs has dbus support Tino Calancha
2018-04-06 8:04 ` Michael Albinus
2018-04-06 8:20 ` Tino Calancha
2018-04-06 9:20 ` Tino Calancha
2018-04-06 9:27 ` Michael Albinus
2018-04-06 9:38 ` Tino Calancha
2018-04-06 9:52 ` Michael Albinus
2018-04-06 10:27 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lge07q59.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).