From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 9a53b6d: Say how to override a primitive interactive spec Date: Sun, 24 Jun 2018 17:09:51 -0500 Message-ID: <87lgb36dlc.fsf@red-bean.com> References: <20180624121111.28772.8847@vcs0.savannah.gnu.org> <20180624121113.215CF206CC@vcs0.savannah.gnu.org> <83d0wgtfa3.fsf@gnu.org> Reply-To: Karl Fogel NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529878167 6899 195.159.176.226 (24 Jun 2018 22:09:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 24 Jun 2018 22:09:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 25 00:09:22 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXDCD-0001g3-Uc for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2018 00:09:22 +0200 Original-Received: from localhost ([::1]:43311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXDEJ-0001lb-Ok for ged-emacs-devel@m.gmane.org; Sun, 24 Jun 2018 18:11:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXDCo-0001Cu-FN for emacs-devel@gnu.org; Sun, 24 Jun 2018 18:09:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXDCk-00057x-56 for emacs-devel@gnu.org; Sun, 24 Jun 2018 18:09:55 -0400 Original-Received: from mail-ot0-x234.google.com ([2607:f8b0:4003:c0f::234]:39993) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXDCk-00057h-0B; Sun, 24 Jun 2018 18:09:54 -0400 Original-Received: by mail-ot0-x234.google.com with SMTP id w9-v6so13013592otj.7; Sun, 24 Jun 2018 15:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=Wz1Nasiw4HeC6+FehcSuqZFhxbdTDVCgnNGOLhFkA5E=; b=iVC4uL/Sld9pIf2jBZYv1s4ye5kN9fMDqE273n9o7ydA2bYCYWjlTzLCFSHv/Pvl+z mz6oaUahbmuANtNdEWvv6kudAX07mfwvHuK99KpktCxtuV1Ao93wd/tUalBhCUxowNwM JoOq2ytdsFZr/Nfq/Tf4E8uRyuAdDrVVe6qliz0uHBx7Abiuf4m2fSnXrEJE0bVGerLp h4eoHyAuGIyPzCTSdtpzvdeqRfl1+DBXIKvCbBqR53bP5gbG8Dvn59l2/uxior5UvydX oyaNNGIIRVHzoVWL6trpdmUMPNpZLZZAOvcb28OmF/iFr26A4p6byvCYtnldHbDF/4dh 6S5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:reply-to :date:in-reply-to:message-id:user-agent:mime-version; bh=Wz1Nasiw4HeC6+FehcSuqZFhxbdTDVCgnNGOLhFkA5E=; b=E1bMppzZfGhMFtNsFXt6djzi3CGSOiydvaz5YFAnNZx2S2giFQVoSaIqH3juHtnLLk iixbG9h2mhbnWmyY2NitPyQIF0+gbwtZJuV217flUpepVVQfNItFqK2SwVfEOZd6UE4U Q/rrX+kcWSR5/4iNR4pBe+XHQbREiEssJLoiTtzc3B/jcHG+7J4vFdpDkR2a6skCDNin 3HcA6t2417XHkH74X3Lvy6Az8y+50U9hh0LdBhh35TDg8kuWlt5wqhUv1k5CLmwH9WHm 42VolxejH2Thnh7y9s8ThN1ezgrLavUgogVPSo6T+L453rPHZxz8zLblsQVZIn4hCulX Jcxg== X-Gm-Message-State: APt69E377vAU6C6ocjzssc9XrnwsDn5pIqYwpsCI4GrLU3agtE5i2fJE B0LGu3z4VQyxF+h48J59ZAnEgA== X-Google-Smtp-Source: AAOMgpfmCIbMH9ZBzSjiROaJgUiFy+3b5summJ5H7Qwc7g8sxnN9xrfWDc+pinaDcvCQDQomEaMYGg== X-Received: by 2002:a9d:132e:: with SMTP id f43-v6mr756433ote.340.1529878192921; Sun, 24 Jun 2018 15:09:52 -0700 (PDT) Original-Received: from klen ([2602:306:3707:da30:f2de:f1ff:fe72:d3f2]) by smtp.gmail.com with ESMTPSA id m17-v6sm6670247otk.1.2018.06.24.15.09.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jun 2018 15:09:52 -0700 (PDT) In-Reply-To: <83d0wgtfa3.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Jun 2018 17:44:52 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226684 Archived-At: Eli Zaretskii writes: >> From: Stefan Monnier >> Date: Sun, 24 Jun 2018 09:42:39 -0400 >> Cc: Karl Fogel >> >> > +If you wish to override a primitive interactive specification, just >> > +set the @code{interactive-form} property of the primitive function's >> > +symbol (@pxref{Using Interactive}). There is no need to edit C code >> > +and recompile Emacs. >> >> You can also use advice-add for the same purpose (it's more >> complicated, but it's arguably better behaved). > >And I wonder whether this text belongs to the "Internals" appendix. I >think its discoverability there will be too low. Why not put it in >"Using Interactive", instead of cross-referencing there? When you say "this text", are you referring to the new text I just added on the emacs-26 branch in commit 9a53b6d426 (quoted above), or to Stefan's proposed new text (not yet written) about recommending `advice-add' instead? I'm pretty sure you meant the latter, but I wanted to make sure of that before commenting further. Best regards, -Karl