From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Tramp and fixnum Date: Sun, 26 Aug 2018 18:44:57 +0200 Message-ID: <87lg8t9iwm.fsf@gmx.de> References: <29f933ac-a6bf-8742-66a7-0a9d6d3e5a88@disroot.org> <877em1cb0i.fsf@tromey.com> <765767b2-d2e5-a9a6-f724-d58ecf4847bb@cs.ucla.edu> <76081b5d-8c10-0a37-2c97-d4864c0faa80@cs.ucla.edu> <09153aed-361d-4f82-d9ac-b502314769ae@cs.ucla.edu> <83lg91dqd4.fsf@gnu.org> <87pny59tz9.fsf_-_@gmx.de> <81bdf4a7-cfa7-40c6-af17-f4f6d6fd8518@cs.ucla.edu> <83sh315cyp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535301797 11828 195.159.176.226 (26 Aug 2018 16:43:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 26 Aug 2018 16:43:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 26 18:43:13 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fty88-0002y0-DC for ged-emacs-devel@m.gmane.org; Sun, 26 Aug 2018 18:43:12 +0200 Original-Received: from localhost ([::1]:49757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftyAE-0007mH-DO for ged-emacs-devel@m.gmane.org; Sun, 26 Aug 2018 12:45:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftyA4-0007hK-Dk for emacs-devel@gnu.org; Sun, 26 Aug 2018 12:45:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ftyA3-0005L3-MI for emacs-devel@gnu.org; Sun, 26 Aug 2018 12:45:12 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:48377) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fty9w-0005B4-RZ; Sun, 26 Aug 2018 12:45:05 -0400 Original-Received: from detlef.gmx.de ([212.86.41.140]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LiIgB-1fXZqi14dv-00nRNd; Sun, 26 Aug 2018 18:44:59 +0200 In-Reply-To: <83sh315cyp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Aug 2018 19:06:54 +0300") X-Provags-ID: V03:K1:SQcUGW3bJ4Fa4lrfiBW8524Ifh4QrkzA5bPbBTuOjOyz+QAOHcm xEZEQY4EMJbg+MobAfbdHpdExVtrqualRNjLVVjs5O+VYhsJanxjwwb458US8bnumATl02O aKW+nreSknn4EYAQKQSXCrJpmjdO6xePp1bTdtJf9xduKvyYMEV23bgz8zEtNlPDJcF2hMT RQYK6kZN9AVnjXGEbNBFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:6/WYfrolkeU=:gBRlpYJ1KjmCxXUHLIQSbj 3+7iz/EF73PB+9WnB7TQbF2inMGk6qiUswZ+9R0iZ6SQEf2J3gcPEx7FPIzYVCUoaVHe/aho8 4SpnFcoIsdpLT5SvnjyS6SiunI8OsrWe1d36Vgd11+TM9ihgO8ZzyRMhl0v324ERSvil9gdkt m/EcgU+sSCp/lAcSPRrBtQaSl45aNBTjdV9tquvcunfDLz/Y08pLuLpRnUZ96OJi/9hAj8kvM SBnnp5kuB4r0uDR5hjm3RT+E0p6oZyFb36sGEJJbu3sQXgoLBCmUcCmotoGw7lGOD9vZBX0hO CddUy0p0K1Gir5iPft3ilhn5pVN7J1mqrCuYFLXkbTxTLYQdpzYb1ot7656nJ8CZ7WJOAn8c6 dG51rRp8pgQdEKnPhrD07qSM/tPQL7ziA6K6UYztVMPax49phazwQ4v1MAxseNtlOOwR82Fgm GLKa93Cct+p+BRUsWyS9eOTAI8J0CrLKFLXuPFJ/ybDLHuCUuDT62QhU9/1fftRi90NXekGu4 6nT9J77+Kky+hwZaUkUxKjn/WWpxAHG76358hR7F5GEoWSuGbYLdWPXQ1h/byhp5kg3njiXsB 07B7SAJACSoWdmu/7G4qMHMsaaKq07Stutjg7MVg6Er55A4fVUWacbYTedcz0+nCKayH6XFri Nk5MuK122n2/WWNEG8nnQm/LHe0h1UuPGm2bzXU6D1SJ9s+YvqcH2taHkPBnpLt93hjKrJQI2 OZmE38gGgu6ilpwDwdMWi2R+K502+Ac82mXuc0iCvA1PaxM0b/wOB3DgUwSd4Qyd/Zj/XiKL X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228940 Archived-At: Eli Zaretskii writes: >> Yes, sorry, I meant 'file-attributes'. The fishy-looking code is in >> tramp-convert-file-attributes. Here's one snippet: >> >> (when (and (floatp (nth 2 attr)) >> (<= (nth 2 attr) most-positive-fixnum)) >> (setcar (nthcdr 2 attr) (round (nth 2 attr)))) >> >> Although this snippet shouldn't hurt, it should be unnecessary once >> file-attributes is fixed to not return floats. > > Fixed in what version of Emacs? Tramp wants to support more than just > the latest master version. Yes, back to Emacs 24. >> The main offender is the inode converter in that function, which >> splits integers >> into three parts, whereas it should simply keep the integers as-is since they >> don't overflow any more. > > They do in older Emacs versions, AFAIR. Yes. See Bug#25854, which triggered this code. It was reported towards Emacs 26.0.50. Best regards, Michael.