From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Minor optimization in json.c Date: Sat, 13 Oct 2018 09:28:24 -0600 Message-ID: <87lg71c1d3.fsf@tromey.com> References: <83efdld3no.fsf@gnu.org> <83zhw8bn1d.fsf@gnu.org> <83worcbbxj.fsf@gnu.org> <83va66ux3x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539444400 26713 195.159.176.226 (13 Oct 2018 15:26:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Oct 2018 15:26:40 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Philipp Stephani , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 13 17:26:36 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBLoF-0006lP-JQ for ged-emacs-devel@m.gmane.org; Sat, 13 Oct 2018 17:26:31 +0200 Original-Received: from localhost ([::1]:45347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBLqM-0003gV-1c for ged-emacs-devel@m.gmane.org; Sat, 13 Oct 2018 11:28:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBLqG-0003gE-54 for emacs-devel@gnu.org; Sat, 13 Oct 2018 11:28:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBLqB-0005au-4P for emacs-devel@gnu.org; Sat, 13 Oct 2018 11:28:36 -0400 Original-Received: from gateway34.websitewelcome.com ([192.185.148.104]:47233) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gBLq9-0005Zu-6s for emacs-devel@gnu.org; Sat, 13 Oct 2018 11:28:31 -0400 Original-Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 24DEB30B7B for ; Sat, 13 Oct 2018 10:28:26 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BLq5gKWSHRPojBLq5gc1jq; Sat, 13 Oct 2018 10:28:26 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=td6dJxOA6ra9BIqnN8HenDJSnF0XPC5uMFVZNwEgu6c=; b=u1rDKKd5tUrxCazHXkFuV1sENp 5No7wqH8YTm7MsQofJb7f+r/vugovig5p6onQEvHL6rHGvYl8sGZMLmvDZBepDzFusZ2FMosKw9iY iDIVgCBficG9abxIzY1biRopT; Original-Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:35232 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gBLq5-000XWu-Kr; Sat, 13 Oct 2018 10:28:25 -0500 X-Attribution: Tom In-Reply-To: <83va66ux3x.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Oct 2018 10:25:22 +0300") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.190.66 X-Source-L: No X-Exim-ID: 1gBLq5-000XWu-Kr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-190-66.hlrn.qwest.net (bapiya) [97.122.190.66]:35232 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.148.104 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230368 Archived-At: >>>>> "Eli" == Eli Zaretskii writes: >> 1. Could you try to eliminate global mutable state (i.e. the >> json_inserted_bytes global variable)? I know that with the current >> threading implementation access is properly synchronized, but the >> global variable is still a code smell and unnecessarily couples >> details of the threading implementation with the JSON adapter code. I >> think you should be able to move it into the json_insert_data or >> json_buffer_and_size structures. Eli> I did that, but it needed adding new members to 2 data structures, and Eli> copying the values back and forth between them. Not sure this is more Eli> elegant. It's also possible to put this sort of thing into the thread object. Tom