From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.devel Subject: Re: removing flatten-list (alias for new flatten-tree function) Date: Mon, 17 Dec 2018 13:00:31 -0600 Message-ID: <87lg4oq8q8.fsf@gmail.com> References: <76ae4692-717a-4e68-e882-453ac8e0df62@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545073458 23016 195.159.176.226 (17 Dec 2018 19:04:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2018 19:04:18 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: "Basil L. Contovounesios" , Michael Albinus , Emacs development discussions To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 17 20:04:14 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYyBa-0005rH-3S for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2018 20:04:14 +0100 Original-Received: from localhost ([::1]:48499 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYyDg-0004wX-Ks for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2018 14:06:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYy8B-0000hG-Pw for emacs-devel@gnu.org; Mon, 17 Dec 2018 14:00:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYy87-00062f-LZ for emacs-devel@gnu.org; Mon, 17 Dec 2018 14:00:43 -0500 Original-Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]:37238) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYy87-0005zd-CW for emacs-devel@gnu.org; Mon, 17 Dec 2018 14:00:39 -0500 Original-Received: by mail-oi1-x22e.google.com with SMTP id y23so11078866oia.4 for ; Mon, 17 Dec 2018 11:00:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=jGzu5Ay3pydHOzstfIealpji+cTFZ7NYM5Sc67Sn1Rs=; b=dLsfta6x0hHWWG8WI82FfMyjQ4BPmEwgQwY71H99dOtV0Cilm8BL46pGWv28UfK7Co lQjBpq+zTEzgWKa1rXOkHTOwX5YGWI9S/0/G7KtZQ6y3gbDhjxxFBHXul6K+Z1lVIo4v SloP/f5nXcc9Tq7cdh9wcFm0ChII6eQvVn2LVRXhVpIcxZy4ZZGnmIsPFFQGv4ikYc8q B5gZFnI1AqZdb7bzAEmOnxrrFnR6B8X9OMW2XPTV2FGj6ewosjS49VO/9BOW0t7Qi1/I pJg9cYSjYHhXLnNkpSK71kM8NKc63D6K+sH3rhhK6y7udPq6F6AKn41ho2YWn+PW+6uS ncmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=jGzu5Ay3pydHOzstfIealpji+cTFZ7NYM5Sc67Sn1Rs=; b=PkDyJ8K7GbjwmQc8MFRvjZJgSPVBpL7dKx1fPJy9gE2euvM0n7kxOW+r4zRkbp32dQ YWqP7WwYByu/Pm/ZKkOIOJ3x6/3xRCgIKgcBrrNwByGNynTHwSVapSXeAA5PvsSugsD5 u5J2ANNsRhkQkHcOkE9Nbvfnl1HulTIHNGD7Hn5txxChc0s02EHAPMLxYMY/oDRz/KX3 r63Jf7W1BEJVbRsziiSRRrNabKoHVFoVthKHAkWr+2QyDky1hhM/6f+ygZg7bCWyk7js slJOJxVPycY7KuLLuI77H90DX77SH+6YlXMakJmRcxIJyPYZSaMFm8szXourtWmEmtzL UDNA== X-Gm-Message-State: AA+aEWYJTl6t4r7ja6bSPFahGIzdlvkcthbuy4rKy+wTRqIlXdZrTSv5 Pi2NUr5mvxq6e41LIG3tY/o= X-Google-Smtp-Source: AFSGD/WASqAFO8yUGk0nwEGiRxEdRU2qotM2Wdn5zZrM4Gpf1lUu1CaP+b+flvwyqCaj+0Uc14b2BQ== X-Received: by 2002:aca:d0c9:: with SMTP id j70mr6332572oiy.143.1545073233588; Mon, 17 Dec 2018 11:00:33 -0800 (PST) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id g25sm6377920otk.31.2018.12.17.11.00.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 11:00:32 -0800 (PST) In-reply-to: <76ae4692-717a-4e68-e882-453ac8e0df62@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231888 Archived-At: On Mon 17 Dec 2018 at 12:40, Paul Eggert wrote: > Thanks for writing the new flatten-tree function and cleaning up > existing duplicate functions. I tweaked its performance a bit and > cleaned up some more duplicates. Thanks! > While doing that I found that I was confused by the existence of the > just-added alias 'flatten-list', and I propose removing it as per the > attached patch. I think people who want to find and use the new > 'flatten-tree' function will typically be better served if it has just > one name that fits in with existing Emacs Lisp functions like > 'copy-tree', as opposed to also having a name that is a misnomer. The reason I included `flatten-list' was that the existing implementations (both inside and outside of Emacs) were nearly all called foo-flatten-list or similar. I thought it would perhaps be easier for people to find `flatten-list' than `flatten-tree'. I don't have a really strong opinion about this, though. Alex