* Re: master 00b8c7e: Make ls-lisp.el behave like Posix hosts when directory doesn't exist
[not found] ` <20190215134658.0E9A3204F1@vcs0.savannah.gnu.org>
@ 2019-02-15 14:10 ` Michael Albinus
2019-02-15 15:41 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2019-02-15 14:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
eliz@gnu.org (Eli Zaretskii) writes:
Hi Eli,
> + ;; Emulate what we do on Posix hosts when we call access-file
> + ;; in insert-directory.
> + (signal 'file-error
> + (list "Reading directory"
> + "Directory doesn't exist or is inaccessible"
> + file))))))
On GNU/Linux, it is `file-missing' (introduced in Emacs 26).
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: master 00b8c7e: Make ls-lisp.el behave like Posix hosts when directory doesn't exist
2019-02-15 14:10 ` master 00b8c7e: Make ls-lisp.el behave like Posix hosts when directory doesn't exist Michael Albinus
@ 2019-02-15 15:41 ` Eli Zaretskii
2019-02-15 15:51 ` Michael Albinus
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2019-02-15 15:41 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 15 Feb 2019 15:10:31 +0100
>
> > + ;; Emulate what we do on Posix hosts when we call access-file
> > + ;; in insert-directory.
> > + (signal 'file-error
> > + (list "Reading directory"
> > + "Directory doesn't exist or is inaccessible"
> > + file))))))
>
> On GNU/Linux, it is `file-missing' (introduced in Emacs 26).
I know. But ls-lisp doesn't know whether it failed because the
directory doesn't exist, or does exist but isn't accessible, and
trying to discern between these two situations doesn't seem worth it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 00b8c7e: Make ls-lisp.el behave like Posix hosts when directory doesn't exist
2019-02-15 15:41 ` Eli Zaretskii
@ 2019-02-15 15:51 ` Michael Albinus
0 siblings, 0 replies; 3+ messages in thread
From: Michael Albinus @ 2019-02-15 15:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
Hi Eli,
>> > + ;; Emulate what we do on Posix hosts when we call access-file
>> > + ;; in insert-directory.
>> > + (signal 'file-error
>> > + (list "Reading directory"
>> > + "Directory doesn't exist or is inaccessible"
>> > + file))))))
>>
>> On GNU/Linux, it is `file-missing' (introduced in Emacs 26).
>
> I know. But ls-lisp doesn't know whether it failed because the
> directory doesn't exist, or does exist but isn't accessible, and
> trying to discern between these two situations doesn't seem worth it.
Hmm. This reminds me, that `tramp-test17-insert-directory' does not
check any error condition. If I would add this, this subtle detail would
count ...
(Not that anybody in real life would care ...)
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-15 15:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190215134656.1071.93029@vcs0.savannah.gnu.org>
[not found] ` <20190215134658.0E9A3204F1@vcs0.savannah.gnu.org>
2019-02-15 14:10 ` master 00b8c7e: Make ls-lisp.el behave like Posix hosts when directory doesn't exist Michael Albinus
2019-02-15 15:41 ` Eli Zaretskii
2019-02-15 15:51 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).