From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF for graphical frames Date: Sun, 28 Apr 2019 21:28:47 -0600 Message-ID: <87lfzto5g0.fsf@gmail.com> References: <20190427033619.18077.55804@vcs0.savannah.gnu.org> <20190427033621.4934B206A2@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="264973"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 29 05:30:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKwzl-0016m5-26 for ged-emacs-devel@m.gmane.org; Mon, 29 Apr 2019 05:30:21 +0200 Original-Received: from localhost ([127.0.0.1]:51343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKwzj-0001yu-RJ for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 23:30:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKwz9-0001yc-W9 for emacs-devel@gnu.org; Sun, 28 Apr 2019 23:29:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKwz9-0003Re-6H for emacs-devel@gnu.org; Sun, 28 Apr 2019 23:29:43 -0400 Original-Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:39872) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKwz3-0003QL-AE; Sun, 28 Apr 2019 23:29:37 -0400 Original-Received: by mail-pl1-x635.google.com with SMTP id e92so4391685plb.6; Sun, 28 Apr 2019 20:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iB8vDqeCYU2D9qXcSrETWi3rVtueQI5/Ytbugj/tLQ4=; b=L0JZj9OoSwoEMjQnLd7gc65LNS0bLs1eaFuAretmCUIaA6I5KkBylT8dyJF1+UMx+y M4drBCdUZBQmN+HeS2zX2dOIkWCndKksGYDBd2cHFcL8HPiOtrQgQIGo3PcUJvRgXMwu BYf2akoQ66fytbkLd4faVNhJ8K7ZynMSojxOc45NIckJYWaPlaIxti+DaElqLMFNpGVI PZEID7AHBojVIrExg5FfbEZ7jvgx+CyTGHVDgrxmJHv3qPGuiy0ck2WDB+JvsEXuJEsQ NdlZHcDbDt8FJV3k8bmbvlo6huejNq0Q5/26cMviOFCiwyRrYxYkJLzpqtdHqFaBVj0S 8OSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iB8vDqeCYU2D9qXcSrETWi3rVtueQI5/Ytbugj/tLQ4=; b=P0LiRmr4FKJN/dLBSJ3yoptYcYzdjMKFm7FasFN3UqvaAWzw+tsKRS5LzU1ERophKc fxMxw1rqn2DRSn8CNigxEl6N1Rz08NR4zRp5avpPLGUBlqYpSTj0RnuvCaLJ9rF5qbZM ANWBbupnIjmpIQQwOTSRF0CumghvsTMXv+hxopWLr99GQZ9idyxS+0ljbQHx4RKeY2x4 MmdgLvpTc9aqMEmeMkddxdsePdrQdpm7vt9mFNb869fVfsbMv0nngQjXUG1JVqdwFJuA 4LgTX9rBw0NgHXa3qtv8LDxNUhjP3OunN3hfK9yA8Fjs53UVtG+2PeXAHdwlBCx2lqzm Nw6Q== X-Gm-Message-State: APjAAAUZR3Yr+dXfLr0MfSrdK3KKGaf5n+RZyHAiY+Xi5ZPZBstYPYDt uCIvKuZygMwalN5hGs4iqWUeyjoH X-Google-Smtp-Source: APXvYqwBAfMnSS5WLMoq9tSpRHj54W8J9xxtxg+tZjHuHBlS8VuBOBHWWf/cbJ+OgUpBbNE+oFAPRQ== X-Received: by 2002:a17:902:4a0c:: with SMTP id w12mr43153689pld.52.1556508575096; Sun, 28 Apr 2019 20:29:35 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id l10sm69921876pfc.46.2019.04.28.20.29.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2019 20:29:34 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 28 Apr 2019 21:50:21 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::635 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236023 Archived-At: Stefan Monnier writes: >> - if (FRAME_RIF (f)->clear_under_internal_border) >> + if (FRAME_WINDOW_P (f) >> + && FRAME_RIF (f)->clear_under_internal_border) > > Wouldn't testing FRAME_RIF(f) instead of FRAME_WINDOW_P(f) make > more sense? At least, it would not rely on the fact that FRAME_RIF(f) > is supposedly non-NULL when FRAME_WINDOW_P(f) is true. > > It'd make the code more "obviously safe". I thought about that, but this way is more consistent with how the other RIF procedures are called in xdisp.c (surrounded by a FRAME_WINDOW_P check somewhere up the chain). I don't have much of a preference, though; Eli, which would you prefer?