unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Gramiak <agrambot@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF for graphical frames
Date: Sun, 28 Apr 2019 21:28:47 -0600	[thread overview]
Message-ID: <87lfzto5g0.fsf@gmail.com> (raw)
In-Reply-To: <jwvmuk9k2d2.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Sun, 28 Apr 2019 21:50:21 -0400")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> -              if (FRAME_RIF (f)->clear_under_internal_border)
>> +              if (FRAME_WINDOW_P (f)
>> +                  && FRAME_RIF (f)->clear_under_internal_border)
>
> Wouldn't testing FRAME_RIF(f) instead of FRAME_WINDOW_P(f) make
> more sense?  At least, it would not rely on the fact that FRAME_RIF(f)
> is supposedly non-NULL when FRAME_WINDOW_P(f) is true.
>
> It'd make the code more "obviously safe".

I thought about that, but this way is more consistent with how the other
RIF procedures are called in xdisp.c (surrounded by a FRAME_WINDOW_P
check somewhere up the chain).

I don't have much of a preference, though; Eli, which would you prefer?



      reply	other threads:[~2019-04-29  3:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190427033619.18077.55804@vcs0.savannah.gnu.org>
     [not found] ` <20190427033621.4934B206A2@vcs0.savannah.gnu.org>
2019-04-29  1:50   ` [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF for graphical frames Stefan Monnier
2019-04-29  3:28     ` Alex Gramiak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfzto5g0.fsf@gmail.com \
    --to=agrambot@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).