From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Sun, 13 Oct 2019 01:47:20 +0300 Organization: LINKOV.NET Message-ID: <87lftp1szr.fsf@mail.linkov.net> References: <20191008160038.6xvnytnoruzphzd6@Ergus> <83zhibw6qn.fsf@gnu.org> <20191008164048.bnad4wdkcbatqepp@Ergus> <83v9szw4o4.fsf@gnu.org> <20191008234350.ahxt4zcylxqludoc@Ergus> <837e5ewc0a.fsf@gnu.org> <20191009103936.qjdwuidqnowswojw@Ergus> <83wodeup6a.fsf@gnu.org> <20191009120534.ud6st2xvrv3rv6iy@Ergus> <83o8yqumdl.fsf@gnu.org> <20191009135539.c2i6ob52td6p34ab@Ergus> <83k19euhic.fsf@gnu.org> <8736g1bl4y.fsf@mail.linkov.net> <83zhi9rqcb.fsf@gnu.org> <877e5cmdpk.fsf@mail.linkov.net> <83wodbprja.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="107925"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: michael_heerdegen@web.de, spacibba@aol.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 13 00:51:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJQDy-000Ruj-JA for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 00:50:59 +0200 Original-Received: from localhost ([::1]:36418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJQDx-00023Y-5W for ged-emacs-devel@m.gmane.org; Sat, 12 Oct 2019 18:50:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42314) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJQDm-0001ul-9g for emacs-devel@gnu.org; Sat, 12 Oct 2019 18:50:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJQDk-0006qA-2y for emacs-devel@gnu.org; Sat, 12 Oct 2019 18:50:45 -0400 Original-Received: from camel.birch.relay.mailchannels.net ([23.83.209.29]:35162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iJQDi-0006pq-E0; Sat, 12 Oct 2019 18:50:42 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C0E49E0648; Sat, 12 Oct 2019 22:50:40 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (100-96-92-142.trex.outbound.svc.cluster.local [100.96.92.142]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1B88AE0B42; Sat, 12 Oct 2019 22:50:40 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 12 Oct 2019 22:50:40 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Trade-Blushing: 1789b96648d1e09c_1570920640374_1902059561 X-MC-Loop-Signature: 1570920640374:2767402675 X-MC-Ingress-Time: 1570920640374 Original-Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id D44F58431C; Sat, 12 Oct 2019 15:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=vsdxIuUPreMpmowFY5bNcquBbdI=; b= 1sTXLzJDlb/dhuqovRyicG6VSWXLc+hGpB+anXoKLId07aYHy6futAU38Ob59IyR rdYQYTwKQsnXttK5FXstuA0aHAqLWe6SP323IGpT4+erj6Nsg5114vGzwHrdbbiZ mvXlaR8nR1In8LzHC9qpXOygfNolE1aN8jCt1DXKoEY= Original-Received: from mail.jurta.org (m91-129-105-34.cust.tele2.ee [91.129.105.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 6E53B827DF; Sat, 12 Oct 2019 15:50:31 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a3 In-Reply-To: <83wodbprja.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Oct 2019 12:20:25 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrieekgdduiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddthedrfeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrfeegpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepvghlihiisehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.209.29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240941 Archived-At: >> @@ -6308,7 +6308,7 @@ focus (where a frame immediately loses focus when it's left by the mouse >> #elif defined (USE_LUCID) || defined (USE_MOTIF) || defined (HAVE_NTGUI) >> frame_inhibit_implied_resize = list2 (Qtab_bar_lines, Qtool_bar_lines); >> #else >> - frame_inhibit_implied_resize = Qnil; >> + frame_inhibit_implied_resize = list1 (Qtab_bar_lines); >> #endif >> #else >> frame_inhibit_implied_resize = Qt; > > Please install the change. We still need to understand why this > default has any effect on the issue, but that's a separate discussion. Actually I don't understand why the no-toolkit case should differ from Lucid, Motif, Windows? They all have non-external tool-bar and tab-bar. Only GTK+ has an external tool-bar, so 'tool-bar-lines' is not included in its default value. Is this a more correct patch? It uses '(tab-bar-lines tool-bar-lines)' in the no-toolkit case as well: diff --git a/src/frame.c b/src/frame.c index 099db29598..fba1ed8970 100644 --- a/src/frame.c +++ b/src/frame.c @@ -6292,12 +6292,11 @@ focus (where a frame immediately loses focus when it's left by the mouse The default value is \\='(tab-bar-lines) in GTK+, (which means that adding/removing a tab bar does not change the frame height), -\\='(tab-bar-lines tool-bar-lines) on Lucid, Motif and Windows -\(which means that adding/removing a tool bar or tab bar does not -change the frame height), nil on all other window systems (which -means that changing any of the parameters listed above may change -the size of the frame), and t otherwise (which means the frame size -never changes implicitly when there's no window system support). +\\='(tab-bar-lines tool-bar-lines) on Lucid, Motif, Windows and on all +other window systems (which means that adding/removing a tool bar or +tab bar does not change the frame height), and t otherwise (which +means the frame size never changes implicitly when there's no window +system support). Note that when a frame is not large enough to accommodate a change of any of the parameters listed above, Emacs may try to enlarge the frame @@ -6305,10 +6304,8 @@ focus (where a frame immediately loses focus when it's left by the mouse #if defined (HAVE_WINDOW_SYSTEM) #if defined USE_GTK frame_inhibit_implied_resize = list1 (Qtab_bar_lines); -#elif defined (USE_LUCID) || defined (USE_MOTIF) || defined (HAVE_NTGUI) +#else frame_inhibit_implied_resize = list2 (Qtab_bar_lines, Qtool_bar_lines); -#else - frame_inhibit_implied_resize = Qnil; #endif #else frame_inhibit_implied_resize = Qt;