From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: philip@warpmail.net (Philip K.) Newsgroups: gmane.emacs.devel Subject: Re: master 421eeff: Add support for multiple Gravatar services Date: Tue, 24 Mar 2020 22:23:16 +0100 Message-ID: <87lfnpsb0b.fsf@bulbul> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="86407"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 25 00:08:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jGseZ-000MNq-6c for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Mar 2020 00:08:11 +0100 Original-Received: from localhost ([::1]:56392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGseY-0002oM-5B for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Mar 2020 19:08:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36217) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGr16-0002jD-NL for emacs-devel@gnu.org; Tue, 24 Mar 2020 17:23:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGr15-0000Wr-Kf for emacs-devel@gnu.org; Tue, 24 Mar 2020 17:23:20 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:33275) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jGr15-0000W4-B4; Tue, 24 Mar 2020 17:23:19 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DF30D5C0216; Tue, 24 Mar 2020 17:23:18 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 24 Mar 2020 17:23:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type; s=fm3; bh=uCV7YNBfE1LBE/KjaefsCmSdnWQ+1CrqbcwHrlq sZQk=; b=dTUcq6gTFPAPoVgnFeQvApn0/gp4LnJWDW9uqkuCmIlj2kGqpAFdPE7 vym4lafBk2/3EratHVJUZS80mHZVEs4pFAkX7ug4lc3nYgZhOSSjmACU7YD70TfN oCQscNKVmsLSUTD2f53yos09rsic+Ho0r6NWBU/dCy+VD8fqwWPi9PFkL5gcqJZt hRnVaqCdNuYFhQbsIlNF3ZU7bXfUJLGSNPqjEuAOcZHxcighj/40eyC84TGajL3A L4Y2PsiwChOoWKq0Qz4quSFgiTdUJWeEk4ABDzelfz1XADAoqy7X6y1w3IX2G2SD enO2wKdZWnXGwwup+ftMcaj1wbeo9nA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=uCV7YNBfE1LBE/Kja efsCmSdnWQ+1CrqbcwHrlqsZQk=; b=WmFlLVg+mJd+F08nilxXH//dAusm16bdS gcHa2pqKihXe4znnd1gJRSZz9VUtAwrp0Pm2M9L8IFT1LGSZj9oQSnz1sBh7O10t WL+bWq2D5Hi++PLeg776VQUlNqCXs7R9tR1kCk5Ojtl29SYX20M6vJTuJtGrpxf0 /0/gIIz5aDhilAQhmqqFT51RxM/i/Rui5i9Pt6x6RBcmQRR3wSQLUICz5Gr6nu4B k9z1dfVwb8OdLAaaKDVe4ZTMhv6w4gKvyHCx5uiaA1Qd+hDPP9pRa78iXsqUjqnq VHyxU+SwzADT0akQDiFx1egXrXT5Kojx6JtRR8NlzXi3bDiuQ5Urw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehuddguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfffkgggtsehmtderre dttddtnecuhfhrohhmpehphhhilhhiphesfigrrhhpmhgrihhlrdhnvghtucdlrfhhihhl ihhpucfmrddmnecukfhppeejledrvdduledrudelledrudeftdenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehphhhilhhiphesfigrrhhpmhgr ihhlrdhnvght X-ME-Proxy: Original-Received: from localhost (p4fdbc782.dip0.t-ipconnect.de [79.219.199.130]) by mail.messagingengine.com (Postfix) with ESMTPA id 680B53065E1B; Tue, 24 Mar 2020 17:23:18 -0400 (EDT) In-Reply-To: (message from Glenn Morris on Tue, 24 Mar 2020 16:45:08 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.27 X-Mailman-Approved-At: Tue, 24 Mar 2020 19:07:04 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245774 Archived-At: --=-=-= Content-Type: text/plain This should fix it. It would be worth considering expanding the test cases too, especially since it's not testing the current default anymore. -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-gravatar-build-url-testcase.patch >From 44014722a5fba37ac3b6625ba7730f125883d789 Mon Sep 17 00:00:00 2001 From: Philip K Date: Tue, 24 Mar 2020 22:19:01 +0100 Subject: [PATCH] Fix gravatar-build-url testcase * test/lisp/image/gravatar-tests.el (gravatar-build-url): Set service type to gravatar --- test/lisp/image/gravatar-tests.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/lisp/image/gravatar-tests.el b/test/lisp/image/gravatar-tests.el index e66b5c6803..77b364073d 100644 --- a/test/lisp/image/gravatar-tests.el +++ b/test/lisp/image/gravatar-tests.el @@ -65,7 +65,8 @@ gravatar-build-url "Test `gravatar-build-url'." (let ((gravatar-default-image nil) (gravatar-force-default nil) - (gravatar-size nil)) + (gravatar-size nil) + (gravatar-service 'gravatar)) (should (equal (gravatar-build-url "foo") "\ https://www.gravatar.com/avatar/acbd18db4cc2f85cedef654fccc4a4d8?r=g")))) -- 2.20.1 --=-=-=--