From: philip@warpmail.net (Philip K.)
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 421eeff: Add support for multiple Gravatar services
Date: Tue, 24 Mar 2020 22:23:16 +0100 [thread overview]
Message-ID: <87lfnpsb0b.fsf@bulbul> (raw)
In-Reply-To: <fo1rph8otn.fsf@fencepost.gnu.org> (message from Glenn Morris on Tue, 24 Mar 2020 16:45:08 -0400)
[-- Attachment #1: Type: text/plain, Size: 161 bytes --]
This should fix it. It would be worth considering expanding the test
cases too, especially since it's not testing the current default
anymore.
--
Philip K.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-gravatar-build-url-testcase.patch --]
[-- Type: text/x-diff, Size: 962 bytes --]
From 44014722a5fba37ac3b6625ba7730f125883d789 Mon Sep 17 00:00:00 2001
From: Philip K <philip@warpmail.net>
Date: Tue, 24 Mar 2020 22:19:01 +0100
Subject: [PATCH] Fix gravatar-build-url testcase
* test/lisp/image/gravatar-tests.el (gravatar-build-url): Set service
type to gravatar
---
test/lisp/image/gravatar-tests.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/lisp/image/gravatar-tests.el b/test/lisp/image/gravatar-tests.el
index e66b5c6803..77b364073d 100644
--- a/test/lisp/image/gravatar-tests.el
+++ b/test/lisp/image/gravatar-tests.el
@@ -65,7 +65,8 @@ gravatar-build-url
"Test `gravatar-build-url'."
(let ((gravatar-default-image nil)
(gravatar-force-default nil)
- (gravatar-size nil))
+ (gravatar-size nil)
+ (gravatar-service 'gravatar))
(should (equal (gravatar-build-url "foo") "\
https://www.gravatar.com/avatar/acbd18db4cc2f85cedef654fccc4a4d8?r=g"))))
--
2.20.1
next prev parent reply other threads:[~2020-03-24 21:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200324170025.21920.7131@vcs0.savannah.gnu.org>
[not found] ` <20200324170026.B097C20E43@vcs0.savannah.gnu.org>
2020-03-24 19:11 ` master 421eeff: Add support for multiple Gravatar services Michael Albinus
2020-03-24 20:21 ` Robert Pluim
2020-03-25 8:54 ` Michael Albinus
2020-03-25 9:15 ` Robert Pluim
2020-03-25 9:24 ` Michael Albinus
2020-03-24 20:45 ` Glenn Morris
2020-03-24 21:15 ` Philip K.
2020-03-24 21:22 ` Robert Pluim
2020-03-24 21:23 ` Philip K. [this message]
2020-03-25 9:07 ` Robert Pluim
2020-03-31 11:42 ` Philip K.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfnpsb0b.fsf@bulbul \
--to=philip@warpmail.net \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).