From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: 31395511: =?utf-8?Q?=22Don=E2=80=99t?= attempt to modify constant strings" Date: Wed, 03 Jun 2020 22:41:54 +0000 Message-ID: <87lfl36abx.fsf@gmail.com> References: <871rmvn7ge.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="19880"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Paul Eggert , emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 04 00:42:55 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgc63-00058v-Jo for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 00:42:55 +0200 Original-Received: from localhost ([::1]:57790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgc62-0006JG-L7 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jun 2020 18:42:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgc5G-0005Zx-S0 for emacs-devel@gnu.org; Wed, 03 Jun 2020 18:42:06 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:36683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgc5F-00022u-Rn for emacs-devel@gnu.org; Wed, 03 Jun 2020 18:42:06 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id d128so3701996wmc.1 for ; Wed, 03 Jun 2020 15:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6hvjtknGU3PbMTxVNy5nqmmfkX+jShTh4j77CncNI/A=; b=RO45AIQXmxVl7FxIDEIMv5A7MDa3ygGSrZUUxidBNKQvAIM13kjK/Wci4YHG34NBY4 U2qPshDIv41cG3pMsGjBOUT4tMXi0cOMCM99T61VZ64CuGymqNsokegEVHpJhPalkUd8 mHD1g2xsiN0zSNyIwK3duOJR7pO4amDwN19n4wZwvcmgxthRhl6117xLD463ULljxOAZ pLfD7Dd6Co73sc2v3mVwXlZseS9CqSEoJ5A1rK7t3xcXkOaJyvx7jlmv1yaoeCCjdTfJ JpiHBGhPFg/cZxIIEyfd+v/VdRsBZmLQYTToIof6GUb000g+GV0QhJFc8vVczm/SmbzP 0jMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6hvjtknGU3PbMTxVNy5nqmmfkX+jShTh4j77CncNI/A=; b=g5q48VilQxdEhucSMLGzRGmOdAp4tKhvNUsNs3dnfEoWADMra4tPzJh9tEelYXWA34 kgaAcMNiKKaVuzsMPjwokFxF9r6OsONvuRCO3yooZNHy+wL7ppBdzllLG6MdvbefZzyo KcxkFmwmcizEsoZSzIjrH3MllSgVsRFwinMNQVT7RT0PWVKhAZqvYNM063JMY5PqV9yf wfuk4vHStloaUCIC41s4uHNTZfbJvKSvX0l3boq8mP+3R/G3dGGmZLbx8i2uFLMLOud9 foVUeWN0eMFXrcA5647JNzmUTsf5vTmKLTEF9x6lWvXtsS+3La0sOPbzo+4nZFIgEYMQ teBg== X-Gm-Message-State: AOAM530/3owz4UE4fuKgI2Dop3rUP0FEcqKeFD7WDrbwozAj73PnMdUb iBQQ9Q7GlAPpHwW/2vKMJHA= X-Google-Smtp-Source: ABdhPJySBx+OL8LjXGiYJ7EjhrVB/sT+0Q/olI9Pmk1YUaGZq8fWI3DMU0CLpp0YUly+RIkPjzv3Rg== X-Received: by 2002:a1c:154:: with SMTP id 81mr1135063wmb.23.1591224121346; Wed, 03 Jun 2020 15:42:01 -0700 (PDT) Original-Received: from chametz ([185.220.101.10]) by smtp.gmail.com with ESMTPSA id c16sm5300459wrx.4.2020.06.03.15.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 15:42:00 -0700 (PDT) In-Reply-To: <871rmvn7ge.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Wed, 03 Jun 2020 22:52:01 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=pipcet@gmail.com; helo=mail-wm1-x330.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251827 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jo=C3=A3o T=C3=A1vora writes: > Hi Paul, > > After a lengthy git bisect, I discovered that this commit is responsible > for breaking a very big part of my SLY extension, a Common Lisp IDE for > Emacs. The reason is this change to make-text-button > > - (when (stringp beg) > - (setq object beg beg 0 end (length object))) > + (setq object (copy-sequence beg) beg 0 end (length object))) > > I don't pretend to understand the reason for the change, but I know it > hasn't worked like this for a long time (SLY came about for Emacs 24.3)., > > I didn't investigate much, but SLY has a lot of > > (insert (sly-make-action-button "[SOMEBUTTON]" ..)) > > and sly-make-action-button is > > (defun sly-make-action-button (label action &rest props) > (apply #'sly--make-text-button > label nil :type 'sly-action > 'action action > 'mouse-action action > props) > label) I think you want (defun sly-make-action-button (label action &rest props) (apply #'sly--make-text-button label nil :type 'sly-action 'action action 'mouse-action action props)) instead, since the new function returns a copy of label rather than the string passed in. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-adjust-to-Emacs-28-change.patch >From d0e06fa8ae4c6d3156dccf922629f91985fd4822 Mon Sep 17 00:00:00 2001 From: Pip Cet Date: Wed, 3 Jun 2020 22:38:37 +0000 Subject: [PATCH] adjust to Emacs-28 change. --- lib/sly-buttons.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/sly-buttons.el b/lib/sly-buttons.el index 8297ea74..8f393090 100644 --- a/lib/sly-buttons.el +++ b/lib/sly-buttons.el @@ -106,8 +106,7 @@ label nil :type 'sly-action 'action action 'mouse-action action - props) - label) + props)) (defface sly-action-face `((t (:inherit warning))) -- 2.27.0.rc0 --=-=-=--