From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Un-deprecating oset Date: Sat, 06 Jun 2020 17:43:33 +0100 Message-ID: <87lfl0jgay.fsf@tcd.ie> References: <87eery1xhe.fsf@bernoul.li> <87a72d42h2.fsf@bernoul.li> <87a726tg3c.fsf@bernoul.li> <877dx1rt78.fsf@bernoul.li> <83zh9wujkx.fsf@gnu.org> <83sgfougls.fsf@gnu.org> <874krsxn48.fsf@tcd.ie> <87img8ulmu.fsf@tcd.ie> <837dwkabjw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="3195"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: jonas@bernoul.li, monnier@iro.umontreal.ca, johnw@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 06 19:47:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhcv8-0000kP-KM for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jun 2020 19:47:50 +0200 Original-Received: from localhost ([::1]:51988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhcv7-0002Vc-LY for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jun 2020 13:47:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhcub-00024w-Jd for emacs-devel@gnu.org; Sat, 06 Jun 2020 13:47:17 -0400 Original-Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:43457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhcua-0002FN-4I for emacs-devel@gnu.org; Sat, 06 Jun 2020 13:47:17 -0400 Original-Received: by mail-qt1-x82c.google.com with SMTP id j32so11369624qte.10 for ; Sat, 06 Jun 2020 10:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bPGxHORtR6qST0ADDiaWR8OGuYQwNnTvFMXhI0CR02Q=; b=sjRyFamnp/WVNgecycklqZBOb8IgEn3DcHZbu0OIWy8roS6+a3gwjwl5xTArXirJAa LMXMQXuzMy/ppZTnUpa28HR/s6DQG1gKBXLmN4klM4uO6rhul5OM1sNtmZi/RJButXkL qDyMdbEZZFgUghxyTq9zsZfrt5RHGYGv53veqWJNy/Y40k16lEvigbeEbhqf1f0uBawD gP/fmpfypXz+DZqpqdREfpBpBGX4JdXh23ouxWq8McMUg+6uTadHWGBdivrvyQCQA+o6 zkokR+0NILF4hNRde/o2kwMqem+0thB10eh+4opF2AjqXk5lCoOuQdhpYU5acpUyjgoW 8S+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bPGxHORtR6qST0ADDiaWR8OGuYQwNnTvFMXhI0CR02Q=; b=l2JAufXRVnQgY2P/80odv1P0YRg0wMnn3LKLczRJdiCfYXK1aSFzhuoBhbJjYTpQcL ippc2bN8gIPwptu0CQ9dtpgSWRdC752yDuipYH1RViFgHPCOlyz3uCZiBm8Qas2t74JS I9y3+dTYkom1wotniTwCk5k2/o3CEICjdUhz71/ALEwCAXP1jZ91IyIKHfJTNa5YxLfW Ipe5JdSqHEraekjnFsjKg4NhqFN5BXljyP/KLepkaRG9BbXKwYzNqI2wnbHxEjtrLdml RjgBHA0JXntq6nw8D9W92QXW228k5Rz89Ch09yKDkkxwdwoTQ7SVjIzwfpDjsuwzv3aS Nk0w== X-Gm-Message-State: AOAM531Mq8dU7rzSHLGgV8BB0aoktRTgcpanQ29juNcswUM62+kamUyI jYNEAlhS/gIsQ9U2wqLbvcYks00GlYMIiQ== X-Google-Smtp-Source: ABdhPJytdiTu//GUM3hO2gsh5l/w8dJPJK6PBzPU0Iid4YXXsyF71zFFROzUzIOYrb+pxtE8Dzn5yQ== X-Received: by 2002:a37:aec3:: with SMTP id x186mr15090071qke.4.1591461815963; Sat, 06 Jun 2020 09:43:35 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id k12sm2454820qkk.58.2020.06.06.09.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2020 09:43:35 -0700 (PDT) In-Reply-To: <837dwkabjw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jun 2020 10:38:43 +0300") Received-SPF: none client-ip=2607:f8b0:4864:20::82c; envelope-from=contovob@tcd.ie; helo=mail-qt1-x82c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251954 Archived-At: Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Cc: Stefan Monnier , jonas@bernoul.li, >> johnw@gnu.org, emacs-devel@gnu.org >> Date: Wed, 03 Jun 2020 18:03:53 +0100 >> >> +@defmac oref obj slot >> +@anchor{oref} >> +This macro retrieves the value stored in @var{obj} in the slot named >> +by @var{slot}. @var{slot} is the name of the slot when created by >> +@dfn{defclass}. > > Two minor stylistic points: Thanks, I incorporated your suggestions and pushed the two patches to master and emacs-27, respectively. Un-deprecate oset and oset-default 8bcc781bc7 2020-06-06 17:24:00 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8bcc781bc762b4082cfd678b88938e3d03465d91 Minor improvements to EDE and EIEIO manuals d8593fd19f 2020-06-06 16:35:52 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d8593fd19ffdb1fa62f0b0c4b971cfdb325fbe1d > . It is many times better to use the argument name as an integral > part of the sentence, instead of separating it. For example: > > This macro retrieves the value stored in @var{obj} in the named > @var{slot}. > > . It is better to avoid starting a sentence with @var{something}, > because in the printed version of the manual @var{..} doesn't > capitalize its argument, so you get a sentence that starts with a > lower-case letter, which is not valid English. (Yes, we have a lot > of examples of this sub-optimal usage our manuals.) In this case, > I would rephrase: > > Slots names are determined by @dfn{defclass} which creates the > slot. > > Btw, why is "defclass" in @dfn here? I saw no reason for it so changed it to @code instead. Thanks, -- Basil