From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jonas@bernoul.li, monnier@iro.umontreal.ca, johnw@gnu.org,
emacs-devel@gnu.org
Subject: Re: Un-deprecating oset
Date: Sat, 06 Jun 2020 17:43:33 +0100 [thread overview]
Message-ID: <87lfl0jgay.fsf@tcd.ie> (raw)
In-Reply-To: <837dwkabjw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jun 2020 10:38:43 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, jonas@bernoul.li,
>> johnw@gnu.org, emacs-devel@gnu.org
>> Date: Wed, 03 Jun 2020 18:03:53 +0100
>>
>> +@defmac oref obj slot
>> +@anchor{oref}
>> +This macro retrieves the value stored in @var{obj} in the slot named
>> +by @var{slot}. @var{slot} is the name of the slot when created by
>> +@dfn{defclass}.
>
> Two minor stylistic points:
Thanks, I incorporated your suggestions and pushed the two patches to
master and emacs-27, respectively.
Un-deprecate oset and oset-default
8bcc781bc7 2020-06-06 17:24:00 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8bcc781bc762b4082cfd678b88938e3d03465d91
Minor improvements to EDE and EIEIO manuals
d8593fd19f 2020-06-06 16:35:52 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d8593fd19ffdb1fa62f0b0c4b971cfdb325fbe1d
> . It is many times better to use the argument name as an integral
> part of the sentence, instead of separating it. For example:
>
> This macro retrieves the value stored in @var{obj} in the named
> @var{slot}.
>
> . It is better to avoid starting a sentence with @var{something},
> because in the printed version of the manual @var{..} doesn't
> capitalize its argument, so you get a sentence that starts with a
> lower-case letter, which is not valid English. (Yes, we have a lot
> of examples of this sub-optimal usage our manuals.) In this case,
> I would rephrase:
>
> Slots names are determined by @dfn{defclass} which creates the
> slot.
>
> Btw, why is "defclass" in @dfn here?
I saw no reason for it so changed it to @code instead.
Thanks,
--
Basil
next prev parent reply other threads:[~2020-06-06 16:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 10:34 Un-deprecating oset Jonas Bernoulli
2020-05-05 10:48 ` Philippe Vaucher
2020-05-05 11:11 ` Basil L. Contovounesios
2020-05-05 14:50 ` Stefan Monnier
2020-05-12 15:06 ` Jonas Bernoulli
2020-05-12 16:49 ` Philippe Vaucher
2020-05-12 21:47 ` Adam Porter
2020-05-13 13:04 ` Philipp Stephani
2020-05-14 7:50 ` Juanma Barranquero
2020-05-14 12:13 ` Basil L. Contovounesios
2020-05-14 12:31 ` Juanma Barranquero
2020-05-17 21:19 ` Jonas Bernoulli
2020-05-24 20:09 ` Jonas Bernoulli
2020-05-25 15:21 ` Eli Zaretskii
2020-05-25 16:06 ` Stefan Monnier
2020-05-25 16:25 ` Eli Zaretskii
2020-06-03 14:03 ` Basil L. Contovounesios
2020-06-03 17:03 ` Basil L. Contovounesios
2020-06-06 7:38 ` Eli Zaretskii
2020-06-06 16:43 ` Basil L. Contovounesios [this message]
2020-06-08 12:42 ` Jonas Bernoulli
2020-05-25 17:27 ` Jonas Bernoulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfl0jgay.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=johnw@gnu.org \
--cc=jonas@bernoul.li \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).