From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master 9ade7ea: Fix Eldoc problem when loading on Emacs 26.3 Date: Fri, 10 Jul 2020 18:54:17 +0100 Message-ID: <87lfjrdzna.fsf@gmail.com> References: <20200710004934.18557.69586@vcs0.savannah.gnu.org> <20200710004936.2935520A27@vcs0.savannah.gnu.org> <0veepjz719.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5194"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , emacs-devel To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 10 19:54:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtxEb-0001F0-Ff for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 19:54:53 +0200 Original-Received: from localhost ([::1]:44588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtxEa-0004iq-DA for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Jul 2020 13:54:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtxE7-0004Jq-4s for emacs-devel@gnu.org; Fri, 10 Jul 2020 13:54:23 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:39649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jtxE5-0001P9-K1; Fri, 10 Jul 2020 13:54:22 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id w3so6730466wmi.4; Fri, 10 Jul 2020 10:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=bc18r5mWFobCVboxk5LMKoJvFWQm2RV12yRDgIYSDBs=; b=s0uF3KgWPKVBLdD5WuloAjKmrtmAcOVndQ5RPPlQWvJd3tMOHG2MqIdXP0LOgSSwac +8NvArr1Tve+9t0IBSh4HbMbnqRe1tEn6z0JuAdY3+mSc6VrLMAikUPAwqDUzCwGxa+P bD4DypNaZqnmeoakrx0BPCbraqr4iK4mm+RsaXaojFbUbdvJX/sygL9m+zV/awi3iWaj nbKEa931zp0zXGe8zLFo76b1J4JTlWHoWAHu5ZfhvaWRQPlkDAu0Q26aHPdFM8jFE+E5 8jHdkBZXn15o8fECcsTwBTyFQLAX8SGmE7sRuRCo27+ORyfXkqppkwZdT1uEGZw/0via 0s4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=bc18r5mWFobCVboxk5LMKoJvFWQm2RV12yRDgIYSDBs=; b=ivqdJGXwM1b6bSn2aaBRbkp6z9chcaoKXH9RekTXzzn9Vqw3IKFgxs9TGYsiinsqZd BBTIrGVuS0szyQpRTEwjEr86l0vo6muC7upzpOF1qZKKn1hGjdZaBXrDwq1njZJTt2+v qmK+ml1QltStGVTSqBh4m6C2G58Aq5i0ZkCcQeZNy8WADNsHuB/bNIW+8H1pzbrl/+c9 nuq7ULEW7cXvNEVYD45MlFU23Kgul4gU/CXJ5Shibq6BlwUMk32UvL80T5FadzHebURn 1Y9WvpzaHjVByPxGDvb5DyQu1xbCOqB0cvhwFLtAF/FuCKM7EVR9jU5LeYHd6mCcCzw1 oang== X-Gm-Message-State: AOAM532Z3e4KhFMuqcpBnSwtx5twAVhSPGw7AFOiFrwK6DNL2BQjBcQW ge5OU1/eysmgPIUek7wJSYKyG2Oi X-Google-Smtp-Source: ABdhPJzVLRDWP82htBz7IkFPDKT0eh3aov39H5zNuqZ7dKqgydYfWZ1Sc6Gqtn7ZBOZYlYv/MtDjLw== X-Received: by 2002:a1c:2485:: with SMTP id k127mr6101131wmk.138.1594403659316; Fri, 10 Jul 2020 10:54:19 -0700 (PDT) Original-Received: from krug ([2001:818:d820:9500:824a:171:15a:2213]) by smtp.gmail.com with ESMTPSA id y16sm11461752wro.71.2020.07.10.10.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 10:54:18 -0700 (PDT) In-Reply-To: (Noam Postavsky's message of "Fri, 10 Jul 2020 13:36:04 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x336.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252830 Archived-At: Noam Postavsky writes: > On Fri, 10 Jul 2020 at 13:10, Jo=C3=A3o T=C3=A1vora wrote: > >> makunbound, as Noam suggested, doesn't work. >> >> Is there an easy way to "unlocalize" a symbol? > > Oh, maybe kill-local-variable? No, that doesn't work either. I was looking at data.c and alloc.c and apparently the only way is really to unintern and re-intern the symbol. But of course that seems to break code that you've loaded before and that expects that symbol in its pre-uninterned state. I've even tried `garbage-collect` to see if I could trigger the sym->u.s.redirect =3D SYMBOL_PLAINVAL from Elisp, but it seems hard. So I'm a bit lost for options to be honest. The problem here, seems to be the fact that eldoc.el is pre-loaded and somehwere in that process the eldoc-documentation-function variable is localized in some buffer. Of course, the problem only manifests itself in practice when you're loading eldoc via package.el in previous Emacs versions, so maybe there's some way to unintern the symbol at package-initialize time. But that probably would break something, too. Maybe come up with a better idea, or maybe, like Stefan suggests, don't make it an alias at all, just deprecate it and keep using it instead of eldoc-documentation-strategy when we find it to be bound. Jo=C3=A3o