From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Mingde (Matthew) Zeng" <matthewzmd@gmail.com>
Cc: Amin Bandali <bandali@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCHv3] erc: fix erc-reuse-buffers behavior
Date: Tue, 04 Aug 2020 10:30:05 +0200 [thread overview]
Message-ID: <87lfiuu836.fsf@gnus.org> (raw)
In-Reply-To: <87k0yfyv1r.fsf@gmail.com> (Mingde Zeng's message of "Mon, 03 Aug 2020 23:00:32 -0400")
"Mingde (Matthew) Zeng" <matthewzmd@gmail.com> writes:
> I had a look at Lars' change, that particular commit simply changes
> target to (not target), it is not enough to fix the problem entirely
> (as outlined in my commit message). Also, changing to (not target)
> technically does avoid this specific problem, but imo it logically
> doesn't make sense. When invoking `erc-generate-new-buffer-name`,
> target is not an optional parameter and should never be nil, that line
> is unnecessary amd therefore removed from my commit.
The only usage of that function is (indirectly) from here:
(defun erc-open (&optional server port nick full-name
connect passwd tgt-list channel process)
[...]
(buffer (erc-get-buffer-create server port channel))
So I assumed that target could indeed be nil -- especially since that
function has always checked whether target is nil or not, only that the
previous check was reverse of what it should have been.
> I have another question, since I've never contributed to Emacs
> directly before, can you tell me is there any way to quickly find out
> whether a bug is tracked by GNU bug reports or not?
The bug tracker has a search field, if that's what you're asking?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-04 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 13:58 [PATCHv3] erc: fix erc-reuse-buffers behavior Mingde (Matthew) Zeng
2020-08-03 15:14 ` Amin Bandali
2020-08-04 3:00 ` Mingde (Matthew) Zeng
2020-08-04 8:30 ` Lars Ingebrigtsen [this message]
2020-08-04 17:08 ` Mingde (Matthew) Zeng
2020-08-04 17:33 ` Lars Ingebrigtsen
2020-08-04 17:36 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfiuu836.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=bandali@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=matthewzmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).