From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Sat, 12 Sep 2020 13:27:26 +0200 Message-ID: <87lfhfgrq9.fsf@gmx.de> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <83a6xve0vq.fsf@gnu.org> <87a6xv456t.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25437"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org, stefan@marxist.se, Daniel =?utf-8?Q?Mart=C3=ADn?= To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 12 13:31:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH3kN-0006Sy-9y for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 13:31:11 +0200 Original-Received: from localhost ([::1]:47422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH3kM-0004kJ-4B for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 07:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH3gq-000340-QU for emacs-devel@gnu.org; Sat, 12 Sep 2020 07:27:32 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:41683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH3go-0007Kk-S7; Sat, 12 Sep 2020 07:27:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599910047; bh=VIjfXBGkTNhzdFwLp864EJiodzYSIIEocNsWCgTlLvY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=DaLuY8vopou8lFjHrEO4Tf32+Qv9qkTJc5NruGcZKsz3nLSxetcztlM13/wVJMYbn zimq7bYeIXhob8uUmXR41vdmK6a4NrqudM5prR9mrLdZYUQoJK6BqNcommhqyxzsDT JDdRvqi3qWaDj96lBEz7H2krNZLQPUfe+hcj50Mo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.41.134]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M42nS-1kH3gl1dUe-0006lY; Sat, 12 Sep 2020 13:27:27 +0200 In-Reply-To: <87a6xv456t.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Sep 2020 13:15:06 +0200") X-Provags-ID: V03:K1:tLmbj/rDlssp4HHRSnWLpPznitH7Y48UY9mi8dhPqQIHBz97i+g VmzXTx9Nk/gnto+nfFdd2b8FXNW3cv1m1c8YFFchLMS9Hyta4Is43qZfgJd2EaPN7IQfQ9F SJ7a+oULsbTia0mf12ttPbyeJ9RgkFNsxnU80XUdPkiv/53w+6NbmVZ1a2u26jKLjWX+9iY wGg8smLSWNziTCvVsKeOA== X-UI-Out-Filterresults: notjunk:1;V03:K0:nqOYqkQNI1s=:fQxpVWTimw9yIJV6nRB3vA kTgLnMnZAZOhCptHvvjZSiV+9G1XSges68g3z4D/dYDPOmHZlZpy0ik7P57dSoYd1GALnx+Mf 9NfcS8vK9X+Pr4zG9odWnEaN3gl5HqMRFd4usu+TLK90LAhL3k3DRL/8xuzHu6/MjXYH8E3/z Y2s+WLllUOM7L7y3EjX1o63jnZx0SgO0rjAly/aZKUmFm0NixRGpGaR9uiNNxZp35Kzn/SfFx aUV5sRepLfKMtizwNwLn25KmOOE7xJK/UfRjsjH9BcjOWvsrDMNZHBRrdOc/BbRKeZWcEuhww W3EDdi5GIW/h58O2mrZXgv3Qpk5uc1p2o6O36p9SlxWABq2AdIwbcw/KYWM5rQxesn2+msQkq tUMzF6l7fFJHwrBmo7O5eMw0dSlT73kPYT8VlERRoWojM5WLRBKNczD4BZIO7kV8dJSTJ/mRx zwhaUvnZ4c0QciVCavYjRASKjZaLkBzUy2Z6dZNGVxVOW+Y0bWuma6cZV9iH1XEXSRwbEpak/ A6aXn4QfWIKl7hT1cFOMqXopEglGo072TAi00DJnvzqj6Tmx7omyUPUGOhVmCfRgeDi/cqpV1 bxkVQ7hrL2Om43jKE44t3OrEonUlkn9OnjdNFs5IEnF7+NvCVos1y3qreFBseHXILinVpdo35 /VvR1G+1CQ09yifj+TlCFpJIwjERSDhvDEmLtvjin/cvof8cdWqTkIED99buJN/SjcRhG/YXW wokQ5sEtXQg246Z/8WABUtZdxo3YQiAGLlZWqrPNSWxNNmHHi7pz29E/lLhcrcVtv/sCV4Ud Received-SPF: pass client-ip=212.227.15.15; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/12 07:27:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255304 Archived-At: Lars Ingebrigtsen writes: >> I also don't understand the more general issue with how long the test >> suite runs. While it runs, you can do something useful on a modern >> system (or just go for a coffee), so why does it matter? > > I appreciate a fast test suite -- I often do a "make check" before > pushing just to see that nothing was inadvertently broken by a > seemingly-innocuous change. > > So I think Stefan K's changes here are correct, and that we should have > small, fast unit tests only in the default "make check", and have the > longer-running integration tests on a different level. (Hydra should > run all these, though, and if it doesn't, that should be changed.) I would agree to move even more checks to :expensive, if we could run them for all major target platforms. But we have only hydra and emba, running on GNU/Linux. Additionally, if we move *all* tests for a given feature to expensive, as Stefan did with autorevert, your "make check" before pushing won't help anymore for this feature. Best regards, Michael.