From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: empty-directory predicate, native implementation Date: Mon, 19 Oct 2020 09:51:55 +0200 Message-ID: <87lfg2zm90.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23568"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Arthur Miller , emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 19 09:56:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUQ29-0005zu-EV for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Oct 2020 09:56:45 +0200 Original-Received: from localhost ([::1]:60052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUQ27-0000lP-Ts for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Oct 2020 03:56:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUPxd-0004cI-QC for emacs-devel@gnu.org; Mon, 19 Oct 2020 03:52:05 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:44983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUPxb-0007tp-99; Mon, 19 Oct 2020 03:52:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603093916; bh=dK08c4oj4vMEVV7orEqYLQNKntBjjpIxJDGSs/GQzEQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=HErvefD261Jg2wqG/G/cjV8F3YcZl1Q1RWn0QckZ3PKEnQwEhbw6YWlgAVcOIp6AT kkrV+sKLvtVDuIa/Z+AUlNn4HHZwJtr0wlLw+36HLMUkAhsZ1tBChluKuFwQPXygD7 IYtU0sMb60eoJkQr2I/2Bh62dQmy5hhrRU/4LzHY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.242.51]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MDhlf-1kcQJf2Mad-00Aq1N; Mon, 19 Oct 2020 09:51:56 +0200 In-Reply-To: (Drew Adams's message of "Sun, 18 Oct 2020 14:13:43 -0700 (PDT)") X-Provags-ID: V03:K1:IBjWOc4usEtltxAmUZaGtuv/lRl1sjHSq42P30VMEoEsD3dQiI2 NHZoynImL7RGg5zSLCD6xg5WEquztBphOoRDikOvW7Cw6SdqOeyChNAb7+cTYj2/Pu9F0YP 46bIucjIzJXKV/I++BGwu0ffTjLNUlKIb4QJCuh5BaWnJR7DudTJkvSg1MTgM719w/3EkO3 o8lalb8RlQGciHoDPVFQg== X-UI-Out-Filterresults: notjunk:1;V03:K0:M/IB2elnmqg=:OHVRQJktHyLCUCH6NjTtvX VCVVsJLaW4spzl+d348pkTdFRiSU9vf+HOiW9FP+GL3rlyGCoCpFkW/PFLukKawU0/6tHdUiE fbYs64zl4kznq/zyiF+K5LeCv6gsqAqNd+YSL5tMTmO92WdgGFgAYFphUXRlM0txAxWccMtSe hmVydVzDMrQkIjA3+apeGdaBJB/ZCWKOnIeqc/VgZAch1u6loPtLJV3uNiM3N3Xlx7hQp2stM tut7RA4+eaXH9KPef6V7zDs1erQyRI1BIOvgrVzKZKr4APPDUDmFQtKCe/DUADDIv6zioRbA+ Yw2kQ/RkNhU6briUV6tpivZgWucIUsaQADkQ6MnjdQdWiFZfyE9C9QV4hCGRsI7lWWLPNzIad hhm6EWSu39p1F558K6eyp5UOu8n7mTBxY40/xPbbPp5P4l6VBW268Pes78uAV4JDJhGLWnT4V aOEjLRXJ5LO/suQ7P4DJmnaYvz1Ku46DQPeN2ZCH0Zox3iMCJxPW7dyz+ICjBfqp1gXYmxs5O LwE4RgCxl7aB/W+V5vPuEvdw3JzUp9s16Nos8z3jUM6ihX7byA/Cy9t+X3SprU34YS1IRT9Oc /hAiqK0q2c4vrH/EzzV2yBoXmNkZQT/wg8IDXb+/WUY4elvgwsBBNKQjTf6L3vDK4FB7aW3ML Mu9AelVEcs6Ldota1of3KdHeVROxMhNwbvzbk2W02q8tMEuxOpg5JOnkh4nzCxGmSTYlgeeUh Uxp+hhxpzF6hJI1TugDY6MlKu6kjOAvYTUQ/UHCWY7+R8LPMlrrAXWlJKWICln5rNq8ghzGZ Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/19 03:52:01 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258096 Archived-At: Drew Adams writes: Hi Drew, > IOW, what's different, AFAICS, is the match data: the match. > > So if you use the regexp only with `string-match-p' (which > doesn't care about the match data), or if you use it only > with `directory-files', then there's no real difference in > the effect. But if you use it for some context where the > matched parts are important, that is, where the match-data > matters, then there's a big difference. Yes. But to be fair, the docstring of directory-files-no-dot-files-regexp didn't promise to return any kind of match data. Using it was just using an undocumented side effect. > I didn't complain about Emacs changing the value of the > variable - no lobbying is needed. What I said was that > "it's not clear to me" why people were claiming that the > new regexp is "more correct" than the old one. (No one > ever responded to that, explaining in what way the old > one was somehow incorrect.) I believe this statement was rather for the different instances of regexps over the code, all of them claiming to match just "." and "..". And some of them might have been wrong. > [BTW, neither manual nor doc string for `directory-files' > says what MATCH is matched against, other than "file names". > But apparently it's matched only against the nondirectory > part of file names, even if FULL is non-nil.] I've fixed the docstrings of directory-files-no-dot-files-regexp, directory-files and directory-files-and-attributes. Best regards, Michael.