From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Ergus <spacibba@aol.com>
Cc: emacs-devel@gnu.org
Subject: Re: Feature branches review please
Date: Wed, 04 Nov 2020 23:18:38 +0000 [thread overview]
Message-ID: <87lffgpv75.fsf@tcd.ie> (raw)
In-Reply-To: <20201104161200.tyeo2r5jibdahukb@Ergus> (Ergus's message of "Wed, 4 Nov 2020 17:12:00 +0100")
Ergus <spacibba@aol.com> writes:
> The icomplete-vertical feature branch is pretty much ready, please if
> any maintainer could give it a last review and tell me anything else
> needed to merge into master?
Thanks. I've never used icomplete before, but FWIW I just gave it a
quick whirl with icomplete-separator set to "\n" and the orderless
package installed, and it seems to work fine.
The only thing that caught my eye in the code is that variables defined
with defvar-local can be set with setq; they don't need setq-local,
since they automatically become buffer-local when set.
> OTOH the highlight-completions branch is almost ready too. I have more
> doubts about this and maybe I will be doing some unneeded things there,
> so maybe a review with some critics and advises will be very very
> welcome.
I have yet to try this branch out, but it sounds cool.
--
Basil
next prev parent reply other threads:[~2020-11-04 23:18 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201104161200.tyeo2r5jibdahukb.ref@Ergus>
2020-11-04 16:12 ` Feature branches review please Ergus
2020-11-04 23:18 ` Basil L. Contovounesios [this message]
2020-11-05 8:30 ` Gregory Heytings via Emacs development discussions.
2020-11-05 10:05 ` Jean Louis
2020-11-05 16:10 ` Gregory Heytings via Emacs development discussions.
2020-11-05 16:27 ` Manuel Uberti
2020-11-05 17:00 ` Gregory Heytings via Emacs development discussions.
2020-11-05 17:32 ` Jean Louis
2020-11-05 18:50 ` Stefan Monnier
2020-11-05 19:30 ` Jean Louis
2020-11-05 19:52 ` Eli Zaretskii
2020-11-05 21:55 ` Adam Porter
2020-11-05 22:18 ` hyperscope Jean Louis
2020-11-06 18:18 ` hyperscope Eduardo Ochs
2020-11-06 19:18 ` hyperscope Jean Louis
2020-11-06 5:50 ` Feature branches review please Jean Louis
2020-11-05 20:39 ` Gregory Heytings via Emacs development discussions.
2020-11-05 21:09 ` Ergus
2020-11-05 21:19 ` Gregory Heytings via Emacs development discussions.
2020-11-05 21:36 ` Jean Louis
2020-11-05 21:44 ` Stefan Monnier
2020-11-05 22:00 ` Gregory Heytings via Emacs development discussions.
2020-11-05 22:36 ` Ergus
2020-11-06 8:42 ` Gregory Heytings via Emacs development discussions.
2020-11-05 21:33 ` Jean Louis
2020-11-05 21:46 ` Basil L. Contovounesios
2020-11-05 22:24 ` Gregory Heytings via Emacs development discussions.
2020-11-05 22:48 ` Jean Louis
2020-11-06 9:19 ` Gregory Heytings via Emacs development discussions.
2020-11-06 10:51 ` Feature branches review please (ivy hello) Jean Louis
2020-11-06 11:17 ` Oleh Krehel
2020-11-06 11:42 ` Jean Louis
2020-11-06 11:49 ` Basil L. Contovounesios
2020-11-06 12:01 ` Jean Louis
2020-11-06 21:12 ` Basil L. Contovounesios
2020-11-06 11:57 ` Could ivy minibuffer stay where it is? Jean Louis
2020-11-06 15:20 ` Basil L. Contovounesios
2020-11-06 15:36 ` Jean Louis
2020-11-06 21:17 ` Basil L. Contovounesios
2020-11-07 12:51 ` Oleh Krehel
2020-11-07 17:23 ` Jean Louis
2020-11-08 11:21 ` Oleh Krehel
2020-11-08 12:51 ` Jean Louis
2020-11-06 13:56 ` Feature branches review please (ivy hello) Stefan Monnier
2020-11-06 14:10 ` Eli Zaretskii
2020-11-06 14:55 ` Stefan Monnier
2020-11-06 15:24 ` Jean Louis
2020-11-06 12:07 ` Gregory Heytings via Emacs development discussions.
2020-11-06 14:02 ` Stefan Monnier
2020-11-06 14:41 ` Gregory Heytings via Emacs development discussions.
2020-11-06 19:23 ` Jean Louis
2020-11-06 21:09 ` Gregory Heytings via Emacs development discussions.
2020-11-15 20:12 ` Feature branches review please Juri Linkov
2020-11-15 22:32 ` Drew Adams
2020-11-06 10:31 ` Alan Mackenzie
2020-11-06 10:55 ` Jean Louis
2020-11-05 17:22 ` Jean Louis
2020-11-05 13:25 ` Andrii Kolomoiets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lffgpv75.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).