xref buffer and default-directory

xref buffer and default-directory

[Matthias Meulien]

Hi, I am a heavy and happy user of project-find-regexp (through 
C-x p g).

Sometime while reading search results from the *xref* buffer I 
realize that I should perform another search; I thus press C-x p g 
again from the *xref* buffer. But it looks like the local value of 
default-directory isn't related to the last search context. And I 
am presented search results of an unrelated project. It's 
confusing and sometimes I take time to realize that am not reading 
the search results of the right project! Are you experiencing the 
same problem?

It looks like the value of default-directory for the *xref* buffer 
is not changed between searches. Is this correct? Should we change 
this behavior?
-- 
Matthias

Re: xref buffer and default-directory

[Dmitry Gutov]

Hi Matthias,

On 08.01.2021 19:15, Matthias Meulien wrote:
> Hi, I am a heavy and happy user of project-find-regexp (through C-x p g).

Excellent!

> Sometime while reading search results from the *xref* buffer I realize 
> that I should perform another search; I thus press C-x p g again from 
> the *xref* buffer. But it looks like the local value of 
> default-directory isn't related to the last search context. And I am 
> presented search results of an unrelated project. It's confusing and 
> sometimes I take time to realize that am not reading the search results 
> of the right project! Are you experiencing the same problem?

Looks like I've never really tried this exact scenario before (I almost 
always search for the string at point, and that means switching to 
another buffer first).

> It looks like the value of default-directory for the *xref* buffer is 
> not changed between searches. Is this correct? Should we change this 
> behavior?

It was a bug (the default-directory value stayed on from the very first 
search you did in the current Emacs session). Should be fixed now in 
6e73e07a6f.

Thanks for the report.

Re: xref buffer and default-directory

[Matthias Meulien]

Dmitry Gutov <dgutov@yandex.ru> writes:

> It was a bug (the default-directory value stayed on from the 
> very first search you did in the current Emacs session). Should 
> be fixed now in 6e73e07a6f.

Yes, I confirm that now when project-find-regexp is called in an 
*xref* buffer the search happens in the expected project. 
> 
> Thanks for the report. 

Welcome!
-- 
Matthias

Re: xref buffer and default-directory

[Juri Linkov]

>> It looks like the value of default-directory for the *xref* buffer is not
>> changed between searches. Is this correct? Should we change
>> this behavior?
>
> It was a bug (the default-directory value stayed on from the very first
> search you did in the current Emacs session). Should be fixed now
> in 6e73e07a6f.

There is still a problem with this:

0. emacs -Q
1. C-x p g
2. Enter a regexp RET, then select a project directory
3. Check 'default-directory' in the xref buffer

It's still the directory of the initial *scratch* buffer,
not a project directory.

Re: xref buffer and default-directory

[Dmitry Gutov]

Hi Juri,

On 03.02.2021 19:16, Juri Linkov wrote:
> There is still a problem with this:
> 
> 0. emacs -Q
> 1. C-x p g
> 2. Enter a regexp RET, then select a project directory
> 3. Check 'default-directory' in the xref buffer
> 
> It's still the directory of the initial*scratch*  buffer,
> not a project directory.

This is a slightly different scenario, requiring support from the 
command implementation. Should be better in c07ebfcbe0.

Re: xref buffer and default-directory

[Dmitry Gutov]

On 09.01.2021 02:17, Dmitry Gutov wrote:
> 
> It was a bug (the default-directory value stayed on from the very first 
> search you did in the current Emacs session). Should be fixed now in 
> 6e73e07a6f.

I'd like to backport this to emacs-27. Eli, may I?

The most recent fix in this discussion (c07ebfcbe0) is less urgent, but 
I could add it too. Both patches are quite simple.

Re: xref buffer and default-directory

[Eli Zaretskii]

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 4 Feb 2021 03:41:40 +0200
> 
> On 09.01.2021 02:17, Dmitry Gutov wrote:
> > 
> > It was a bug (the default-directory value stayed on from the very first 
> > search you did in the current Emacs session). Should be fixed now in 
> > 6e73e07a6f.
> 
> I'd like to backport this to emacs-27. Eli, may I?
> 
> The most recent fix in this discussion (c07ebfcbe0) is less urgent, but 
> I could add it too. Both patches are quite simple.

OK for backporting both.

Thanks.

Re: xref buffer and default-directory

[Juri Linkov]

>> There is still a problem with this:
>> 0. emacs -Q
>> 1. C-x p g
>> 2. Enter a regexp RET, then select a project directory
>> 3. Check 'default-directory' in the xref buffer
>> It's still the directory of the initial*scratch*  buffer,
>> not a project directory.
>
> This is a slightly different scenario, requiring support from the command
> implementation. Should be better in c07ebfcbe0.

Thanks, I confirm this is fixed.

Re: xref buffer and default-directory

[Dmitry Gutov]

On 04.02.2021 16:55, Eli Zaretskii wrote:
>> I'd like to backport this to emacs-27. Eli, may I?
>>
>> The most recent fix in this discussion (c07ebfcbe0) is less urgent, but
>> I could add it too. Both patches are quite simple.
> OK for backporting both.
> 
> Thanks.

Done, thank you.