From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 12409c9: New transient mode 'repeat-mode' to allow shorter key sequences (bug#46515) Date: Thu, 18 Feb 2021 11:37:19 +0200 Organization: LINKOV.NET Message-ID: <87lfbln1w8.fsf@mail.linkov.net> References: <20210217180506.28704.14280@vcs0.savannah.gnu.org> <20210217180507.C061220DFB@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21179"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 18 10:59:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCg5r-0005MR-3R for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 10:59:31 +0100 Original-Received: from localhost ([::1]:38410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCg5q-0005Fj-3I for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 04:59:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCfzl-0004f3-PV for emacs-devel@gnu.org; Thu, 18 Feb 2021 04:53:13 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:5631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCfzj-000174-VJ for emacs-devel@gnu.org; Thu, 18 Feb 2021 04:53:13 -0500 X-Originating-IP: 91.129.96.116 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id E95CA240011; Thu, 18 Feb 2021 09:53:05 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 17 Feb 2021 23:39:44 -0500") Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265133 Archived-At: >> +(defvar next-error-repeat-map >> + (let ((map (make-sparse-keymap))) >> + (define-key map "n" 'next-error) >> + (define-key map "\M-n" 'next-error) >> + (define-key map "p" 'previous-error) >> + (define-key map "\M-p" 'previous-error) >> + map) >> + "Keymap to repeat next-error key sequences. Used in `repeat-mode'.") >> +(put 'next-error 'repeat-map 'next-error-repeat-map) >> +(put 'previous-error 'repeat-map 'next-error-repeat-map) > > Could we avoid this duplication between the map and the > `repeat-map` property? > >> + (set-transient-map map))))))) > > For example passing a second argument t to `set-transient-map` makes > `set-transient-map` look to see if the key just typed was found in the > map and if so keep the transient alive, which seems to [after an > admittedly cursory check of the code] play the same role as what your > `repeat-map` property does, but without the duplication. The current design relies on post-command-hook that runs after every command. Using the second argument KEEP-PRED of set-transient-map will add duplication: the same map will be set by both post-command-hook and KEEP-PRED. So currently there is no duplication. But is it possible to avoid duplication when using KEEP-PRED too? Could post-command-hook detect that KEEP-PRED is in use for the next command, and not to call set-transient-map again?