From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 9291e73 02/12: Add new 'declare' forms for command completion predicates Date: Fri, 26 Feb 2021 11:34:23 +0000 Message-ID: <87lfbb12rk.fsf@tcd.ie> References: <20210214131500.30678.63538@vcs0.savannah.gnu.org> <20210214131502.DADCE20DFB@vcs0.savannah.gnu.org> <874ki6v8ob.fsf@tcd.ie> <874ki5lfyl.fsf@gnus.org> <871rd9mrye.fsf@tcd.ie> <87y2fhifgj.fsf@gnus.org> <87tuq5h00b.fsf@tcd.ie> <87r1l9gtni.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6471"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 26 12:35:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFbOt-0001X7-MN for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Feb 2021 12:35:15 +0100 Original-Received: from localhost ([::1]:51340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFbOs-0001XS-PK for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Feb 2021 06:35:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFbOA-00017O-Be for emacs-devel@gnu.org; Fri, 26 Feb 2021 06:34:30 -0500 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:42256) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFbO8-00028s-9c for emacs-devel@gnu.org; Fri, 26 Feb 2021 06:34:30 -0500 Original-Received: by mail-wr1-x431.google.com with SMTP id r3so8241523wro.9 for ; Fri, 26 Feb 2021 03:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hyetzguslgkm2bVybeecbOtOu05yxDpwecC7iJXJBeY=; b=NJTwenkaTObAQlCn4TCuSBKRO4s3vrSo9wa9DGmuJJ5nL2XSwoQ8Urf9r98oPnSCJ0 TQwp0uW6BbJDeXrhiNB2L6RYdpN86OLJCmQmKxWy/CycORSHXDfrwIjdPUOj8NtNb6K+ g4Q34X1BQ+xmT8mHkjuhcC0TNgwgNIiIq1mN5IjOC+110gDKf0pg3krst4on4XNWuApX FQNnbciHUSeGOcEd1FP62EVtg+Ur4AbxfLQC3yuztVBRbUirYDv25008+JIfth5dezNZ xE66QgL6MoIU6g3VPCugDUFSGHnhii5RTVVGYZBHodykvjKW9kTxHfjbxCeRHbiHjPYV Dq7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hyetzguslgkm2bVybeecbOtOu05yxDpwecC7iJXJBeY=; b=MYPtk2V0w6Vs0ZZEyjVd6IJbFHSkaIoNHDztY/j9a3bKk7TFVDWUWw1pIcoKR9ppaE KKc6+vmJJi0yKBUu20tbQRNL444HlZRBkETNTtbPxTRZGGiazIplSS+vMIjI1mH9j+EK yry/dlAVyv6yHKnfGo8X9tLJrY6foIr9VezmiDgvyQ1g4l7l6UNU9q0DURbvHfcedY+4 0qJSv1BpaUZfzvFIrYeq01lF+6Ocf+3Fwl4KNpkib8w5hNFOMQQ9jMxdUCT90XQ0KnSb sQWXCJpwlfJyKdW+Hv+kQ4nnKSboJjigYvAh0Qye3IWMoin/e+Sqt/LqLBx047WlhgjJ 98Ug== X-Gm-Message-State: AOAM532T/4pAuCZXWl0PikNDD2Lf1lGwugFOxuxqoJfYZtQQa78DoLI2 +IHYExdp/7j9ME+j29wbRVi2ENYASYTJcA== X-Google-Smtp-Source: ABdhPJzK8yDfsporor605o1PtF9mncaKkdPI4H6/1MkBz2awnqsA0pB21w23jpvMo60DYeKEkGwPmQ== X-Received: by 2002:adf:f648:: with SMTP id x8mr2738240wrp.157.1614339265964; Fri, 26 Feb 2021 03:34:25 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:6d2d:c2fa:f3fa:cabd]) by smtp.gmail.com with ESMTPSA id r7sm13169528wre.25.2021.02.26.03.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Feb 2021 03:34:25 -0800 (PST) In-Reply-To: <87r1l9gtni.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 21 Feb 2021 19:30:57 +0100") Received-SPF: none client-ip=2a00:1450:4864:20::431; envelope-from=contovob@tcd.ie; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265675 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> Why should explicit #'-quoting be needed for (declare (completion foo)) >> when it's not needed for any other declare form property, including the >> new and related 'modes' property: >> >> (declare (modes foo)) >> (declare (gv-setter foo)) >> (declare (gv-expander foo)) >> (declare (obsolete foo ...)) >> (declare (interactive-only foo)) >> (declare (compiler-macro foo)) >> (declare (indent foo)) >> >> How is (declare (completion ...)) any different to these? > > Most of those refer to symbols (or numbers), so #'-ing is irrelevant. > But gv-setter (for one) does refer to a function, so there's precedence > for using symbols instead of functions here indeed. > > Anybody else have an opinion? It seems there were no objections, so I applied the patch. Function-quote completion property of declare form 752278834b 2021-02-26 11:26:22 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=752278834b3d317a65135cdaa392b0468ce7372c Thanks, -- Basil