From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Tue, 09 Mar 2021 11:05:54 +0200 Organization: LINKOV.NET Message-ID: <87lfawk7qt.fsf@mail.linkov.net> References: <83zgzsq7xn.fsf@gnu.org> <83v9afriqp.fsf@gnu.org> <83zgzjhvdn.fsf@gnu.org> <83a6rhxwah.fsf@gnu.org> <837dmlxspt.fsf@gnu.org> <834khpxr0s.fsf@gnu.org> <8335x8ybw9.fsf@gnu.org> <87czwageno.fsf@mail.linkov.net> <877dmhwnfu.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14174"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , "larsi@gnus.org" , Drew Adams , "emacs-devel@gnu.org" To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 09 10:26:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJYdg-0003ap-Up for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Mar 2021 10:26:52 +0100 Original-Received: from localhost ([::1]:55706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJYdf-0001d7-Ut for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Mar 2021 04:26:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJYbz-0000hO-19 for emacs-devel@gnu.org; Tue, 09 Mar 2021 04:25:16 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:51063) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJYbw-0002OK-At; Tue, 09 Mar 2021 04:25:06 -0500 X-Originating-IP: 91.129.108.46 Original-Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id D17CF2000C; Tue, 9 Mar 2021 09:24:55 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Tue, 9 Mar 2021 01:38:40 -0600") Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266234 Archived-At: >> It would be nice to keep the current face 'help-key-binding' >> even after adding links. > > Yes, as it happens that is exactly what I'm currently experimenting > with. See the attached patch if you want to try it out; I think the > effect is quite nice. Thanks, I tested your patch and everything is nice. > But I'm seeing bootstrap problems if I flip the new option here to t, so > we couldn't use it as the default in its current form. > > [The problem is that the button type `help-function' is defined in > help-mode.el, but that file is not autoloaded (and help.el is). There > are several ways to fix it, but I haven't yet had time to think about > which is better. (For example, we could force the option to nil during > bootstrap. Or we could just move the button definitions into its own > file or into help.el to make sure they are there during bootstrap.) ] Enabling it by default would be nice too if you will find a solution for bootstraping problem. Here's what it looks like when trying to bootstrap: ELC emacs-lisp/autoload.elc Debugger entered--Lisp error: (void-function help-mode--add-function-link) (help-mode--add-function-link key fun) ... substitute-command-keys("Memory exhausted--use \\[save-some-buffers] then ex...") ... command-line() So either the option should be disabled or the function be available during bootstrap.